Remove $gotGreater/$gotSmaller in favor of direct $newMin/$newMax comparisons

Simplify the integer generalization logic in generalizeType() by removing
the $gotGreater and $gotSmaller boolean flags. Instead, compute $newMin/$newMax
in the same loop and check $newMax > $max / $newMin < $min directly.

Also applies the symmetric fix for integer ranges (was still using
new IntegerType() instead of IntegerRangeType::fromInterval()).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: phpstan-bot

src/Analyser/MutatingScope.php

@@ -4100,26 +4100,20 @@ private function generalizeType(Type $a, Type $b, int $depth): Type
 
 					$newMin = $min;
 					$newMax = $max;
-					$gotGreater = false;
-					$gotSmaller = false;
 					foreach ($constantIntegers['b'] as $int) {
-						if ($int->getValue() > $max) {
+						if ($int->getValue() > $newMax) {
 							$newMax = $int->getValue();
-							$gotGreater = true;
 						}
-						if ($int->getValue() >= $min) {
-							continue;
+						if ($int->getValue() < $newMin) {
+							$newMin = $int->getValue();
 						}
-
-						$newMin = $int->getValue();
-						$gotSmaller = true;
 					}
 
-					if ($gotGreater && $gotSmaller) {
+					if ($newMax > $max && $newMin < $min) {
 						$resultTypes[] = IntegerRangeType::fromInterval($newMin, $newMax);
-					} elseif ($gotGreater) {
+					} elseif ($newMax > $max) {
 						$resultTypes[] = IntegerRangeType::fromInterval($min, null);
-					} elseif ($gotSmaller) {
+					} elseif ($newMin < $min) {
 						$resultTypes[] = IntegerRangeType::fromInterval(null, $max);
 					} else {
 						$resultTypes[] = TypeCombinator::union($constantIntegersA, $constantIntegersB);
@@ -4164,8 +4158,8 @@ private function generalizeType(Type $a, Type $b, int $depth): Type
 						$max = $rangeMax;
 					}
 
-					$gotGreater = false;
-					$gotSmaller = false;
+					$newMin = $min;
+					$newMax = $max;
 					foreach ($integerRanges['b'] as $range) {
 						if ($range->getMin() === null) {
 							$rangeMin = PHP_INT_MIN;
@@ -4178,14 +4172,12 @@ private function generalizeType(Type $a, Type $b, int $depth): Type
 							$rangeMax = $range->getMax();
 						}
 
-						if ($rangeMax > $max) {
-							$gotGreater = true;
+						if ($rangeMax > $newMax) {
+							$newMax = $rangeMax;
 						}
-						if ($rangeMin >= $min) {
-							continue;
+						if ($rangeMin < $newMin) {
+							$newMin = $rangeMin;
 						}
-
-						$gotSmaller = true;
 					}
 
 					if ($min === PHP_INT_MIN) {
@@ -4194,12 +4186,18 @@ private function generalizeType(Type $a, Type $b, int $depth): Type
 					if ($max === PHP_INT_MAX) {
 						$max = null;
 					}
+					if ($newMin === PHP_INT_MIN) {
+						$newMin = null;
+					}
+					if ($newMax === PHP_INT_MAX) {
+						$newMax = null;
+					}
 
-					if ($gotGreater && $gotSmaller) {
-						$resultTypes[] = new IntegerType();
-					} elseif ($gotGreater) {
+					if ($newMax !== $max && $newMin !== $min) {
+						$resultTypes[] = IntegerRangeType::fromInterval($newMin, $newMax);
+					} elseif ($newMax !== $max) {
 						$resultTypes[] = IntegerRangeType::fromInterval($min, null);
-					} elseif ($gotSmaller) {
+					} elseif ($newMin !== $min) {
 						$resultTypes[] = IntegerRangeType::fromInterval(null, $max);
 					} else {
 						$resultTypes[] = TypeCombinator::union($integerRangesA, $integerRangesB);