only in immediately invoked

Author: staabm

src/Analyser/MutatingScope.php

@@ -50,6 +50,7 @@
 use PHPStan\Node\Printer\ExprPrinter;
 use PHPStan\Node\PropertyAssignNode;
 use PHPStan\Parser\ArrayMapArgVisitor;
+use PHPStan\Parser\ImmediatelyInvokedClosureVisitor;
 use PHPStan\Parser\NewAssignedToPropertyVisitor;
 use PHPStan\Parser\Parser;
 use PHPStan\Php\PhpVersion;
@@ -3714,6 +3715,7 @@ private function enterAnonymousFunctionWithoutReflection(
 				&& $expr->var instanceof Variable
 				&& is_string($expr->var->name)
 				&& $expr->var->name === 'this'
+				&& $closure->getAttribute(ImmediatelyInvokedClosureVisitor::ATTRIBUTE_NAME) === true
 				&& !$closure->static
 				&& $this->hasVariableType('this')->yes()
 				&& $this->phpVersion->supportsReadOnlyProperties()

tests/PHPStan/Analyser/nsrt/bug-13321.php

@@ -29,10 +29,17 @@ public function bar(): void
 			return;
 		}
 
-		$test = function () {
+		(function () {
 			assertType(Foo::class, $this->foo);
 			assertType(Foo::class.'|null', $this->writableFoo);
 
+			echo $this->foo->value;
+		})();
+
+		$test = function () {
+			assertType(Foo::class.'|null', $this->foo);
+			assertType(Foo::class.'|null', $this->writableFoo);
+
 			echo $this->foo->value;
 		};
 

tests/PHPStan/Analyser/nsrt/bug-13321b.php

@@ -32,7 +32,7 @@ public function bar(): void
 		assertType('non-empty-string', $this->foo->value);
 
 		$test = function () {
-			assertType(Foo::class, $this->foo);
+			assertType(Foo::class.'|null', $this->foo);
 			assertType('string', $this->foo->value);
 		};