[BE] Require RuleErrorBuilder and identifiers in custom rules

Author: ondrejmirtes

UPGRADING.md

@@ -68,6 +68,28 @@ Now, `throw $e;` is represented as a `Stmt\Expression` that contains an `Expr\Th
 
 See [UPGRADING](https://github.com/phpstan/phpdoc-parser/blob/2.0.x/UPGRADING.md) guide for phpstan/phpdoc-parser.
 
+### Returning plain strings as errors no longer supported, use RuleErrorBuilder
+    *
+Identifiers are also required in custom rules.
+
+Learn more: [Using RuleErrorBuilder to enrich reported errors in custom rules](https://phpstan.org/blog/using-rule-error-builder)
+
+Before:
+
+```php
+return ['My error'];
+```
+
+After:
+
+```php
+return [
+    RuleErrorBuilder::mesage('My error')
+        ->identifier('my.error')
+        ->build(),
+];
+```
+
 ### Changed `TypeSpecifier::create()` and `SpecifiedTypes` constructor parameters
 
 [`PHPStan\Analyser\TypeSpecifier::create()`](https://apiref.phpstan.org/2.0.x/PHPStan.Analyser.TypeSpecifier.html#_create) now accepts (all parameters are required):

changelog-2.0.md

@@ -89,8 +89,6 @@ Bleeding edge (TODO move to other sections)
 * BetterNoopRule - take advantage of impure points (https://github.com/phpstan/phpstan-src/commit/a6470521b65d7424f552633c1f3827704c6262c3), #10389
 * Run missing type check on `@param-out` (https://github.com/phpstan/phpstan-src/commit/56b20024386d983927c64dfa895ff026bed2798c)
 * CallToConstructorStatementWithoutSideEffectsRule - report class with no constructor (https://github.com/phpstan/phpstan-src/commit/b116d25a6e4ba6c09f59af6569d9e6f6fd20aff4)
-* Deprecated: returning plain strings as errors, use RuleErrorBuilder
-    * Learn more: [Using RuleErrorBuilder to enrich reported errors in custom rules](https://phpstan.org/blog/using-rule-error-builder)
 * Check if required file exists ([#3294](https://github.com/phpstan/phpstan-src/pull/3294)), #3397, thanks @Bellangelo!
 * Check generics `@method` `@template` tags above traits (https://github.com/phpstan/phpstan-src/commit/aadbf62d3ae4517fc7a212b07130bedcef8d13ac)
 * Check `@mixin` PHPDoc tag above traits (https://github.com/phpstan/phpstan-src/commit/0d0de946900adf4eb3c799b1b547567536e23147)
@@ -138,6 +136,8 @@ Improvements 🔧
 * Analysis with zero files results in non-zero exit code (https://github.com/phpstan/phpstan-src/commit/46ff440648e62617df86aa74ba905ffa99897737), #9410
 * Fail build when project config uses custom extensions outside of analysed paths
     * This will only occur after a run that uses already present and valid result cache
+* Returning plain strings as errors no longer supported, use RuleErrorBuilder
+    * Learn more: [Using RuleErrorBuilder to enrich reported errors in custom rules](https://phpstan.org/blog/using-rule-error-builder)
 * Require identifier in custom rules (https://github.com/phpstan/phpstan-src/commit/969e6fa31d5484d42dab902703cfc6820a983cfd)
 
 Bugfixes 🐛

conf/bleedingEdge.neon

@@ -57,5 +57,3 @@ parameters:
 		explicitThrow: true
 		absentTypeChecks: true
 		requireFileExists: true
-	stubFiles:
-		- ../stubs/bleedingEdge/Rule.stub

src/Rules/Rule.php

@@ -32,7 +32,7 @@ public function getNodeType(): string;
 
 	/**
 	 * @phpstan-param TNodeType $node
-	 * @return (string|RuleError)[] errors
+	 * @return list<IdentifierRuleError>
 	 */
 	public function processNode(Node $node, Scope $scope): array;