Respect calling scope visibility and __isset for non-public properties

- Use scope->canReadProperty() instead of isPublic() to match PHP's
  actual behavior (array_column respects calling context)
- When __isset is defined on the class, treat non-accessible private
  properties as maybe-accessible (returns generic array)
- Add tests for child class accessing protected parent properties
  and __isset interaction

Author: janedbal

src/Type/Php/ArrayColumnFunctionReturnTypeExtension.php

@@ -172,7 +172,12 @@ private function getOffsetOrProperty(Type $type, Type $offsetOrProperty, Scope $
 				}
 
 				$property = $type->getProperty($propertyName, $scope);
-				if (!$property->isPublic()) {
+				if (!$scope->canReadProperty($property)) {
+					foreach ($type->getObjectClassReflections() as $classReflection) {
+						if ($classReflection->hasMethod('__isset')) {
+							return $allowMaybe ? new MixedType() : null;
+						}
+					}
 					continue;
 				}
 

tests/PHPStan/Analyser/nsrt/array-column-php82.php

@@ -264,7 +264,55 @@ class ArrayColumnVisibilityFromInsideTest
 	public function testFromInside(array $objects): void
 	{
 		assertType('list<int>', array_column($objects, 'pub'));
+		assertType('list<int>', array_column($objects, 'priv'));
+	}
+
+}
+
+class ObjectWithIsset
+{
+	public int $pub = 1;
+	private int $priv = 2;
+
+	public function __isset(string $name): bool
+	{
+		return true;
+	}
+
+	public function __get(string $name): mixed
+	{
+		return $this->$name;
+	}
+}
+
+class ArrayColumnVisibilityFromChildTest extends ObjectWithVisibility
+{
+
+	/** @param list<ObjectWithVisibility> $objects */
+	public function testFromChild(array $objects): void
+	{
+		assertType('list<int>', array_column($objects, 'pub'));
+		assertType('list<int>', array_column($objects, 'prot'));
 		assertType('array{}', array_column($objects, 'priv'));
 	}
 
 }
+
+class ArrayColumnVisibilityWithIssetTest
+{
+
+	/** @param array<int, ObjectWithIsset> $objects */
+	public function testWithIsset(array $objects): void
+	{
+		assertType('list<int>', array_column($objects, 'pub'));
+		assertType('list', array_column($objects, 'priv'));
+	}
+
+	/** @param array{ObjectWithIsset} $objects */
+	public function testWithIssetConstant(array $objects): void
+	{
+		assertType('array{int}', array_column($objects, 'pub'));
+		assertType('list', array_column($objects, 'priv'));
+	}
+
+}

tests/PHPStan/Analyser/nsrt/array-column.php

@@ -278,7 +278,55 @@ class ArrayColumnVisibilityFromInsideTest
 	public function testFromInside(array $objects): void
 	{
 		assertType('list<int>', array_column($objects, 'pub'));
+		assertType('list<int>', array_column($objects, 'priv'));
+	}
+
+}
+
+class ObjectWithIsset
+{
+	public int $pub = 1;
+	private int $priv = 2;
+
+	public function __isset(string $name): bool
+	{
+		return true;
+	}
+
+	public function __get(string $name): mixed
+	{
+		return $this->$name;
+	}
+}
+
+class ArrayColumnVisibilityFromChildTest extends ObjectWithVisibility
+{
+
+	/** @param list<ObjectWithVisibility> $objects */
+	public function testFromChild(array $objects): void
+	{
+		assertType('list<int>', array_column($objects, 'pub'));
+		assertType('list<int>', array_column($objects, 'prot'));
 		assertType('array{}', array_column($objects, 'priv'));
 	}
 
 }
+
+class ArrayColumnVisibilityWithIssetTest
+{
+
+	/** @param array<int, ObjectWithIsset> $objects */
+	public function testWithIsset(array $objects): void
+	{
+		assertType('list<int>', array_column($objects, 'pub'));
+		assertType('list', array_column($objects, 'priv'));
+	}
+
+	/** @param array{ObjectWithIsset} $objects */
+	public function testWithIssetConstant(array $objects): void
+	{
+		assertType('array{int}', array_column($objects, 'pub'));
+		assertType('list', array_column($objects, 'priv'));
+	}
+
+}