Infer non-empty-array after array_key_first/last()

Author: staabm

src/Analyser/TypeSpecifier.php

@@ -2346,6 +2346,21 @@ public function resolveIdentical(Expr\BinaryOp\Identical $expr, Scope $scope, Ty
 			}
 		}
 
+		// array_key_first($a) !== null
+		// array_key_last($a) !== null
+		if (
+			$unwrappedLeftExpr instanceof FuncCall
+			&& $unwrappedLeftExpr->name instanceof Name
+			&& in_array($unwrappedLeftExpr->name->toLowerString(), ['array_key_first', 'array_key_last'], true)
+			&& isset($unwrappedLeftExpr->getArgs()[0])
+			&& $rightType->isNull()->yes()
+		) {
+			$argType = $scope->getType($unwrappedLeftExpr->getArgs()[0]->value);
+			if ($argType->isArray()->yes()) {
+				return $this->create($unwrappedLeftExpr->getArgs()[0]->value, new NonEmptyArrayType(), $context->negate(), $scope)->setRootExpr($expr);
+			}
+		}
+
 		// preg_match($a) === $b
 		if (
 			$context->true()

tests/PHPStan/Analyser/nsrt/bug-13546.php

@@ -0,0 +1,37 @@
+<?php
+namespace Bug13546;
+
+use function PHPStan\Testing\assertType;
+
+/** @param array<int> $array */
+function first(array $array): void
+{
+	if (array_key_first($array) !== null) {
+		assertType('non-empty-array<int>', $array);
+	} else {
+		assertType('array{}', $array);
+	}
+	assertType('array<int>', $array);
+}
+
+/** @param array<int> $array */
+function firstReversed(array $array): void
+{
+	if (null !== array_key_first($array)) {
+		assertType('non-empty-array<int>', $array);
+	} else {
+		assertType('array{}', $array);
+	}
+	assertType('array<int>', $array);
+}
+
+/** @param array<int> $array */
+function last(array $array): void
+{
+	if (array_key_last($array) !== null) {
+		assertType('non-empty-array<int>', $array);
+	} else {
+		assertType('array{}', $array);
+	}
+	assertType('array<int>', $array);
+}