Bleeding edge - enforce @no-named-arguments

Author: ondrejmirtes

src/Analyser/ArgumentsNormalizer.php

@@ -27,7 +27,7 @@ final class ArgumentsNormalizer
 	public const ORIGINAL_ARG_ATTRIBUTE = 'originalArg';
 
 	/**
-	 * @return array{ParametersAcceptor, FuncCall}|null
+	 * @return array{ParametersAcceptor, FuncCall, bool}|null
 	 */
 	public static function reorderCallUserFuncArguments(
 		FuncCall $callUserFuncCall,
@@ -65,18 +65,24 @@ public static function reorderCallUserFuncArguments(
 			return null;
 		}
 
+		$callableParametersAcceptors = $calledOnType->getCallableParametersAcceptors($scope);
 		$parametersAcceptor = ParametersAcceptorSelector::selectFromArgs(
 			$scope,
 			$passThruArgs,
-			$calledOnType->getCallableParametersAcceptors($scope),
+			$callableParametersAcceptors,
 			null,
 		);
 
+		$acceptsNamedArguments = true;
+		foreach ($callableParametersAcceptors as $callableParametersAcceptor) {
+			$acceptsNamedArguments = $acceptsNamedArguments && $callableParametersAcceptor->acceptsNamedArguments();
+		}
+
 		return [$parametersAcceptor, new FuncCall(
 			$callbackArg->value,
 			$passThruArgs,
 			$callUserFuncCall->getAttributes(),
-		)];
+		), $acceptsNamedArguments];
 	}
 
 	public static function reorderFuncArguments(

src/Analyser/MutatingScope.php

@@ -1361,6 +1361,7 @@ static function (Node $node, Scope $scope) use ($arrowScope, &$arrowFunctionImpu
 						$cachedClosureData['impurePoints'],
 						$cachedClosureData['invalidateExpressions'],
 						$cachedClosureData['usedVariables'],
+						true,
 					);
 				}
 				if (self::$resolveClosureTypeDepth >= 2) {
@@ -1575,6 +1576,7 @@ static function (Node $node, Scope $scope) use ($arrowScope, &$arrowFunctionImpu
 				$impurePointsForClosureType,
 				$invalidateExpressions,
 				$usedVariables,
+				true,
 			);
 		} elseif ($node instanceof New_) {
 			if ($node->class instanceof Name) {
@@ -2523,9 +2525,11 @@ private function createFirstClassCallable(
 
 			$throwPoints = [];
 			$impurePoints = [];
+			$acceptsNamedArguments = true;
 			if ($variant instanceof CallableParametersAcceptor) {
 				$throwPoints = $variant->getThrowPoints();
 				$impurePoints = $variant->getImpurePoints();
+				$acceptsNamedArguments = $variant->acceptsNamedArguments();
 			} elseif ($function !== null) {
 				$returnTypeForThrow = $variant->getReturnType();
 				$throwType = $function->getThrowType();
@@ -2549,6 +2553,8 @@ private function createFirstClassCallable(
 				if ($impurePoint !== null) {
 					$impurePoints[] = $impurePoint;
 				}
+
+				$acceptsNamedArguments = $function->acceptsNamedArguments();
 			}
 
 			$parameters = $variant->getParameters();
@@ -2564,6 +2570,7 @@ private function createFirstClassCallable(
 				$impurePoints,
 				[],
 				[],
+				$acceptsNamedArguments,
 			);
 		}
 

src/PhpDoc/TypeNodeResolver.php

@@ -961,7 +961,7 @@ function (CallableTypeParameterNode $parameterNode) use ($nameScope, &$isVariadi
 				),
 			]);
 		} elseif ($mainType instanceof ClosureType) {
-			$closure = new ClosureType($parameters, $returnType, $isVariadic, $templateTypeMap, null, null, $templateTags, [], $mainType->getImpurePoints());
+			$closure = new ClosureType($parameters, $returnType, $isVariadic, $templateTypeMap, null, null, $templateTags, [], $mainType->getImpurePoints(), $mainType->getInvalidateExpressions(), $mainType->getUsedVariables(), $mainType->acceptsNamedArguments());
 			if ($closure->isPure()->yes() && $returnType->isVoid()->yes()) {
 				return new ErrorType();
 			}

src/Reflection/Annotations/AnnotationMethodReflection.php

@@ -141,6 +141,11 @@ public function getAsserts(): Assertions
 		return Assertions::createEmpty();
 	}
 
+	public function acceptsNamedArguments(): bool
+	{
+		return $this->declaringClass->acceptsNamedArguments();
+	}
+
 	public function getSelfOutType(): ?Type
 	{
 		return null;

src/Reflection/BetterReflection/BetterReflectionProvider.php

@@ -280,6 +280,7 @@ private function getCustomFunction(string $functionName): PhpFunctionReflection
 		$isFinal = false;
 		$isPure = null;
 		$asserts = Assertions::createEmpty();
+		$acceptsNamedArguments = true;
 		$phpDocComment = null;
 		$phpDocParameterOutTags = [];
 		$phpDocParameterImmediatelyInvokedCallable = [];
@@ -305,6 +306,7 @@ private function getCustomFunction(string $functionName): PhpFunctionReflection
 			if ($resolvedPhpDoc->hasPhpDocString()) {
 				$phpDocComment = $resolvedPhpDoc->getPhpDocString();
 			}
+			$acceptsNamedArguments = $resolvedPhpDoc->acceptsNamedArguments();
 			$phpDocParameterOutTags = $resolvedPhpDoc->getParamOutTags();
 			$phpDocParameterImmediatelyInvokedCallable = $resolvedPhpDoc->getParamsImmediatelyInvokedCallable();
 			$phpDocParameterClosureThisTypeTags = $resolvedPhpDoc->getParamClosureThisTags();
@@ -323,6 +325,7 @@ private function getCustomFunction(string $functionName): PhpFunctionReflection
 			$reflectionFunction->getFileName() !== false ? $reflectionFunction->getFileName() : null,
 			$isPure,
 			$asserts,
+			$acceptsNamedArguments,
 			$phpDocComment,
 			array_map(static fn (ParamOutTag $paramOutTag): Type => $paramOutTag->getType(), $phpDocParameterOutTags),
 			$phpDocParameterImmediatelyInvokedCallable,

src/Reflection/CallableFunctionVariantWithPhpDocs.php

@@ -35,6 +35,7 @@ public function __construct(
 		private array $impurePoints,
 		private array $invalidateExpressions,
 		private array $usedVariables,
+		private bool $acceptsNamedArguments,
 	)
 	{
 		parent::__construct(
@@ -74,4 +75,9 @@ public function getUsedVariables(): array
 		return $this->usedVariables;
 	}
 
+	public function acceptsNamedArguments(): bool
+	{
+		return $this->acceptsNamedArguments;
+	}
+
 }

src/Reflection/Callables/CallableParametersAcceptor.php

@@ -19,6 +19,8 @@ public function getThrowPoints(): array;
 
 	public function isPure(): TrinaryLogic;
 
+	public function acceptsNamedArguments(): bool;
+
 	/**
 	 * @return SimpleImpurePoint[]
 	 */

src/Reflection/Callables/FunctionCallableVariant.php

@@ -163,4 +163,9 @@ public function getUsedVariables(): array
 		return [];
 	}
 
+	public function acceptsNamedArguments(): bool
+	{
+		return $this->function->acceptsNamedArguments();
+	}
+
 }

src/Reflection/Dummy/ChangedTypeMethodReflection.php

@@ -107,6 +107,11 @@ public function getAsserts(): Assertions
 		return $this->reflection->getAsserts();
 	}
 
+	public function acceptsNamedArguments(): bool
+	{
+		return $this->reflection->acceptsNamedArguments();
+	}
+
 	public function getSelfOutType(): ?Type
 	{
 		return $this->reflection->getSelfOutType();

src/Reflection/Dummy/DummyConstructorReflection.php

@@ -111,6 +111,11 @@ public function getAsserts(): Assertions
 		return Assertions::createEmpty();
 	}
 
+	public function acceptsNamedArguments(): bool
+	{
+		return $this->declaringClass->acceptsNamedArguments();
+	}
+
 	public function getSelfOutType(): ?Type
 	{
 		return null;