Fix non empty array with lot of optional keys

Author: VincentLanglet

src/Type/Constant/ConstantArrayType.php

@@ -216,6 +216,8 @@ public function getAllArrays(): array
 		} else {
 			$optionalKeysCombinations = [
 				[],
+				array_slice($this->optionalKeys, 0, 1, true),
+				array_slice($this->optionalKeys, -1, 1, true),
 				$this->optionalKeys,
 			];
 		}

tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php

@@ -1060,6 +1060,14 @@ public function testBug7143(): void
 				"Offset 'bar' might not exist on non-empty-array{foo?: string, bar?: string}.",
 				13,
 			],
+			[
+				"Offset 'foo' might not exist on non-empty-array{foo?: string, bar?: string, 1?: 1, 2?: 2, 3?: 3, 4?: 4, 5?: 5, 6?: 6, ...}.",
+				21,
+			],
+			[
+				"Offset 'bar' might not exist on non-empty-array{foo?: string, bar?: string, 1?: 1, 2?: 2, 3?: 3, 4?: 4, 5?: 5, 6?: 6, ...}.",
+				22,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Arrays/data/bug-7143.php

@@ -12,4 +12,13 @@ public function test(array $arr): void
 		echo $arr['foo'];
 		echo $arr['bar'];
 	}
+
+	/**
+	 * @param array{foo?: string, bar?: string, 1?:1, 2?:2, 3?:3, 4?:4, 5?:5, 6?:6, 7?:7, 8?:8, 9?:9}&non-empty-array $arr
+	 */
+	public function test2(array $arr): void
+	{
+		echo $arr['foo'];
+		echo $arr['bar'];
+	}
 }