TableErrorFormatter: improve formatting of error tips

Author: FeBe95

src/Command/ErrorFormatter/TableErrorFormatter.php

@@ -16,6 +16,7 @@
 use function in_array;
 use function is_string;
 use function ltrim;
+use function rtrim;
 use function sprintf;
 use function str_contains;
 use function str_replace;
@@ -83,7 +84,7 @@ public function formatErrors(
 				$filePath = $error->getTraitFilePath() ?? $error->getFilePath();
 				if ($error->getIdentifier() !== null && $error->canBeIgnored()) {
 					$message .= "\n";
-					$message .= '🪪  ' . $error->getIdentifier();
+					$message .= '🪪 ' . $error->getIdentifier();
 				}
 				if ($error->getTip() !== null) {
 					$tip = $error->getTip();
@@ -95,6 +96,7 @@ public function formatErrors(
 						foreach ($lines as $line) {
 							$message .= '💡 ' . ltrim($line, ' •') . "\n";
 						}
+						$message = rtrim($message, "\n");
 					} else {
 						$message .= '💡 ' . $tip;
 					}
@@ -116,7 +118,7 @@ public function formatErrors(
 						$title = $this->relativePathHelper->getRelativePath($filePath);
 					}
 
-					$message .= "\n✏️  <href=" . OutputFormatter::escape($url) . '>' . $title . '</>';
+					$message .= "\n✏️ <href=" . OutputFormatter::escape($url) . '>' . $title . '</>';
 				}
 
 				if (

tests/PHPStan/Command/ErrorFormatter/TableErrorFormatterTest.php

@@ -190,13 +190,13 @@ public function dataFormatterOutputProvider(): iterable
 			'numGenericErrors' => 0,
 			'verbose' => false,
 			'extraEnvVars' => [],
-			'expected' => ' ------ ----------------
+			'expected' => ' ------ ---------------
   Line   foo.php
- ------ ----------------
+ ------ ---------------
   5      Foobar\Buz
-         🪪  foobar.buz
+         🪪 foobar.buz
          💡 a tip
- ------ ----------------
+ ------ ---------------
 
 
  [ERROR] Found 1 error
@@ -211,13 +211,13 @@ public function dataFormatterOutputProvider(): iterable
 			'numGenericErrors' => 0,
 			'verbose' => true,
 			'extraEnvVars' => [],
-			'expected' => ' ------ ----------------
+			'expected' => ' ------ ---------------
   Line   foo.php
- ------ ----------------
+ ------ ---------------
   5      Foobar\Buz
-         🪪  foobar.buz
+         🪪 foobar.buz
          💡 a tip
- ------ ----------------
+ ------ ---------------
 
 
  [ERROR] Found 1 error