Validate all possible cases

Author: Bellangelo

src/Rules/Keywords/RequireFileExistsRule.php

@@ -27,14 +27,18 @@ public function getNodeType(): string
 
 	public function processNode(Node $node, Scope $scope): array
 	{
-		$filePath = $this->resolveFilePath($node, $scope);
-		if (is_string($filePath) && !is_file($filePath)) {
-			return [
-				$this->getErrorMessage($node, $filePath),
-			];
+		$errors = [];
+		$paths = $this->resolveFilePaths($node, $scope);
+
+		foreach ($paths as $path) {
+			if (is_file($path)) {
+				continue;
+			}
+
+			$errors[] = $this->getErrorMessage($node, $path);
 		}
 
-		return [];
+		return $errors;
 	}
 
 	private function getErrorMessage(Include_ $node, string $filePath): IdentifierRuleError
@@ -69,12 +73,20 @@ private function getErrorMessage(Include_ $node, string $filePath): IdentifierRu
 		)->nonIgnorable()->identifier($identifier)->build();
 	}
 
-	private function resolveFilePath(Include_ $node, Scope $scope): ?string
+	/**
+	 * @return array<string>
+	 */
+	private function resolveFilePaths(Include_ $node, Scope $scope): array
 	{
+		$paths = [];
 		$type = $scope->getType($node->expr);
-		$paths = $type->getConstantStrings();
+		$constantStrings = $type->getConstantStrings();
+
+		foreach ($constantStrings as $constantString) {
+			$paths[] = $constantString->getValue();
+		}
 
-		return isset($paths[0]) ? $paths[0]->getValue() : null;
+		return $paths;
 	}
 
 }

tests/PHPStan/Rules/Keywords/RequireFileExistsRuleTest.php

@@ -136,6 +136,28 @@ public function testFileExistsUsingVariables(): void
 		$this->analyse([__DIR__ . '/data/file-exists-using-a-variable.php'], []);
 	}
 
+	public function testFileDoesNotExistConditionally(): void
+	{
+		$this->analyse([__DIR__ . '/data/file-does-not-exist-conditionally.php'], [
+			[
+				'Path in include() "a-file-that-does-not-exist.php" is not a file or it does not exist.',
+				9,
+			],
+			[
+				'Path in include_once() "a-file-that-does-not-exist.php" is not a file or it does not exist.',
+				10,
+			],
+			[
+				'Path in require() "a-file-that-does-not-exist.php" is not a file or it does not exist.',
+				11,
+			],
+			[
+				'Path in require_once() "a-file-that-does-not-exist.php" is not a file or it does not exist.',
+				12,
+			],
+		]);
+	}
+
 	public function testFileDoesNotExistButUsesVariables(): void
 	{
 		$this->analyse([__DIR__ . '/data/file-does-not-exist-but-uses-a-variable.php'], [

tests/PHPStan/Rules/Keywords/data/file-does-not-exist-conditionally.php

@@ -0,0 +1,12 @@
+<?php declare(strict_types=1);
+
+$path = __DIR__ . '/include-me-to-prove-you-work.txt';
+
+if (rand(0,1)) {
+	$path = 'a-file-that-does-not-exist.php';
+}
+
+include $path;
+include_once $path;
+require $path;
+require_once $path;