Fix forgetting static property access after impure call

Author: staabm

src/Analyser/MutatingScope.php

@@ -4379,6 +4379,14 @@ private function shouldInvalidateExpression(string $exprStringToInvalidate, Expr
 		$nodeFinder = new NodeFinder();
 		$expressionToInvalidateClass = get_class($exprToInvalidate);
 		$found = $nodeFinder->findFirst([$expr], function (Node $node) use ($expressionToInvalidateClass, $exprStringToInvalidate): bool {
+			if (
+				$exprStringToInvalidate === '$this'
+				&& $node instanceof Name
+				&& in_array($node->name, ['self', 'static', 'parent'], true)
+			) {
+				return true;
+			}
+
 			if (!$node instanceof $expressionToInvalidateClass) {
 				return false;
 			}

tests/PHPStan/Analyser/nsrt/bug-12902-non-strict.php

@@ -72,8 +72,8 @@ public function __construct()
 		assertNativeType('int', self::$i);
 
 		$this->impureCall();
-		assertType('int', self::$i); // should be float|int
-		assertNativeType('int', self::$i); // should be float|int
+		assertType('float|int', self::$i);
+		assertNativeType('float|int', self::$i);
 	}
 
 	public function doFoo(): void {

tests/PHPStan/Analyser/nsrt/bug-12902.php

@@ -72,8 +72,8 @@ public function __construct()
 		assertNativeType('int', self::$i);
 
 		$this->impureCall();
-		assertType('int', self::$i); // should be float|int
-		assertNativeType('int', self::$i); // should be float|int
+		assertType('float|int', self::$i);
+		assertNativeType('float|int', self::$i);
 	}
 
 	public function doFoo(): void {
@@ -85,6 +85,33 @@ public function doFoo(): void {
 	public function impureCall(): void {}
 }
 
+class BaseClass
+{
+	static protected int|float $i;
+}
+
+class UsesBaseClass extends BaseClass
+{
+	public function __construct()
+	{
+		parent::$i = getInt();
+		assertType('int', parent::$i);
+		assertNativeType('int', parent::$i);
+
+		$this->impureCall();
+		assertType('float|int', parent::$i);
+		assertNativeType('float|int', parent::$i);
+	}
+
+	public function doFoo(): void {
+		assertType('float|int', parent::$i);
+		assertNativeType('float|int', parent::$i);
+	}
+
+	/** @phpstan-impure  */
+	public function impureCall(): void {}
+}
+
 function getInt(): int {
 	return 1;
 }