Prevent unnecesary calls to isSuperTypeOf

staabm · ondrejmirtes · commit 7a078520bbff · 2024-06-18T11:40:00.000+02:00
diff --git a/src/Reflection/InitializerExprTypeResolver.php b/src/Reflection/InitializerExprTypeResolver.php
@@ -1350,9 +1350,7 @@ public function resolveIdenticalType(Type $leftType, Type $rightType): BooleanTy
 			return new ConstantBooleanType($leftTypeFiniteTypes[0]->equals($rightTypeFiniteType[0]));
 		}
 
-		$isLeftSupertype = $leftType->isSuperTypeOf($rightType);
-		$isRightSupertype = $rightType->isSuperTypeOf($leftType);
-		if ($isLeftSupertype->no() && $isRightSupertype->no()) {
+		if ($leftType->isSuperTypeOf($rightType)->no() && $rightType->isSuperTypeOf($leftType)->no()) {
 			return new ConstantBooleanType(false);
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -1350,9 +1350,7 @@ public function resolveIdenticalType(Type $leftType, Type $rightType): BooleanTy`
`1350`	`1350`	`return new ConstantBooleanType($leftTypeFiniteTypes[0]->equals($rightTypeFiniteType[0]));`
`1351`	`1351`	`}`
`1352`	`1352`
`1353`		`- $isLeftSupertype = $leftType->isSuperTypeOf($rightType);`
`1354`		`- $isRightSupertype = $rightType->isSuperTypeOf($leftType);`
`1355`		`- if ($isLeftSupertype->no() && $isRightSupertype->no()) {`
	`1353`	`+ if ($leftType->isSuperTypeOf($rightType)->no() && $rightType->isSuperTypeOf($leftType)->no()) {`
`1356`	`1354`	`return new ConstantBooleanType(false);`
`1357`	`1355`	`}`
`1358`	`1356`