[BE] Specify explicit mixed array type via is_array

Author: ondrejmirtes

changelog-2.0.md

@@ -60,7 +60,6 @@ Bleeding edge (TODO move to other sections)
 =====================
 
 * Report useless `array_filter()` calls ([#1077](https://github.com/phpstan/phpstan-src/pull/1077)), #6840, thanks @leongersen!
-* Specify explicit mixed array type via `is_array` ([#1191](https://github.com/phpstan/phpstan-src/pull/1191)), thanks @herndlm!
 * Rules for checking direct calls to `__construct()` (level 2) ([#1208](https://github.com/phpstan/phpstan-src/pull/1208)), #7022, thanks @muno92!
 * ConstantLooseComparisonRule - level 4 (https://github.com/phpstan/phpstan-src/commit/6ebf2361a3c831dd105a815521889428c295dc9f)
 * Support `@readonly` property and `@immutable` class PHPDoc ([#1295](https://github.com/phpstan/phpstan-src/pull/1295), [#1335](https://github.com/phpstan/phpstan-src/pull/1335)), #4082, thanks @herndlm!
@@ -128,6 +127,7 @@ Improvements 🔧
 * Fix position variance of static method parameters ([#2313](https://github.com/phpstan/phpstan-src/pull/2313)), thanks @jiripudil!
 * Empty `skipCheckGenericClasses` (https://github.com/phpstan/phpstan-src/commit/28c2c79b16cac6ba6b01f1b4d211541dd49d8a77)
 * Report unnecessary nullsafe property fetch inside `??` / `isset` / `empty` with different message ([#1253](https://github.com/phpstan/phpstan-src/pull/1253)), thanks @rajyan!
+* Specify explicit mixed array type via `is_array` ([#1191](https://github.com/phpstan/phpstan-src/pull/1191)), thanks @herndlm!
 
 Bugfixes 🐛
 =====================

conf/bleedingEdge.neon

@@ -4,7 +4,6 @@ parameters:
 		skipCheckGenericClasses!: []
 		stricterFunctionMap: true
 
-		explicitMixedViaIsArray: true
 		arrayFilter: true
 		arrayValues: true
 		looseComparison: true

conf/config.neon

@@ -24,7 +24,6 @@ parameters:
 		bleedingEdge: false
 		disableRuntimeReflectionProvider: true
 		skipCheckGenericClasses: []
-		explicitMixedViaIsArray: false
 		arrayFilter: false
 		arrayValues: false
 		illegalConstructorMethodCall: false
@@ -1722,8 +1721,6 @@ services:
 		class: PHPStan\Type\Php\IsArrayFunctionTypeSpecifyingExtension
 		tags:
 			- phpstan.typeSpecifier.functionTypeSpecifyingExtension
-		arguments:
-			explicitMixed: %featureToggles.explicitMixedViaIsArray%
 
 	-
 		class: PHPStan\Type\Php\IsCallableFunctionTypeSpecifyingExtension

conf/parametersSchema.neon

@@ -30,7 +30,6 @@ parametersSchema:
 		bleedingEdge: bool(),
 		disableRuntimeReflectionProvider: bool(),
 		skipCheckGenericClasses: listOf(string()),
-		explicitMixedViaIsArray: bool(),
 		arrayFilter: bool(),
 		arrayValues: bool(),
 		illegalConstructorMethodCall: bool(),

src/Type/Php/IsArrayFunctionTypeSpecifyingExtension.php

@@ -20,10 +20,6 @@ final class IsArrayFunctionTypeSpecifyingExtension implements FunctionTypeSpecif
 
 	private TypeSpecifier $typeSpecifier;
 
-	public function __construct(private bool $explicitMixed)
-	{
-	}
-
 	public function isFunctionSupported(FunctionReflection $functionReflection, FuncCall $node, TypeSpecifierContext $context): bool
 	{
 		return strtolower($functionReflection->getName()) === 'is_array'
@@ -39,7 +35,7 @@ public function specifyTypes(FunctionReflection $functionReflection, FuncCall $n
 			throw new ShouldNotHappenException();
 		}
 
-		return $this->typeSpecifier->create($node->getArgs()[0]->value, new ArrayType(new MixedType($this->explicitMixed), new MixedType($this->explicitMixed)), $context, $scope);
+		return $this->typeSpecifier->create($node->getArgs()[0]->value, new ArrayType(new MixedType(true), new MixedType(true)), $context, $scope);
 	}
 
 	public function setTypeSpecifier(TypeSpecifier $typeSpecifier): void