Added regression tests

Author: staabm

tests/PHPStan/Analyser/nsrt/bug13674a.php

@@ -14,10 +14,16 @@ public function sayHello($arrayA, $listA, int $i): void
 	{
 		if (array_key_exists($i, $arrayA)) {
 			assertType('non-empty-array<int>', $arrayA);
+		} else {
+			assertType('array<int>', $arrayA);
 		}
+		assertType('array<int>', $arrayA);
 
 		if (array_key_exists($i, $listA)) {
 			assertType('non-empty-list<int>', $listA);
+		} else {
+			assertType('list<int>', $listA);
 		}
+		assertType('list<int>', $listA);
 	}
 }

tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php

@@ -1113,4 +1113,11 @@ public function testBug12805(): void
 		$this->analyse([__DIR__ . '/data/bug-12805.php'], []);
 	}
 
+	public function testBug3795(): void
+	{
+		$this->reportPossiblyNonexistentGeneralArrayOffset = true;
+
+		$this->analyse([__DIR__ . '/data/bug-3795.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Arrays/data/bug-3795.php

@@ -0,0 +1,41 @@
+<?php
+
+namespace Bug3795;
+
+class User {
+	private string $id;
+	private string $name;
+
+	public function __construct(string $id, string $name) {
+		$this->id = $id;
+		$this->name = $name;
+	}
+
+	public function getId() : string {
+		return $this->id;
+	}
+
+	public function getName() : string {
+		return $this->name;
+	}
+}
+
+class Users {
+	/**
+	 * @param array{id?: string, name?: string} $data
+	 */
+	public static function create(array $data) : User {
+		// The following generates a warning
+
+		foreach (['id', 'name'] as $required) {
+			if (!array_key_exists($required, $data)) {
+				throw new InvalidArgumentException('Data is missing ' . $required);
+			}
+		}
+
+		return new User(
+			(string) $data['id'],
+			(string) $data['name'],
+		);
+	}
+}