Fix ReadOnlyByPhpDocPropertyAssignRule for hooked properties

Author: ondrejmirtes

src/Rules/Properties/ReadOnlyByPhpDocPropertyAssignRule.php

@@ -7,6 +7,7 @@
 use PHPStan\Node\PropertyAssignNode;
 use PHPStan\Reflection\ConstructorsHelper;
 use PHPStan\Reflection\MethodReflection;
+use PHPStan\Reflection\Php\PhpMethodFromParserNodeReflection;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\ShouldNotHappenException;
@@ -40,6 +41,18 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
+		$inFunction = $scope->getFunction();
+		if (
+			$inFunction instanceof PhpMethodFromParserNodeReflection
+			&& $inFunction->isPropertyHook()
+			&& $propertyFetch->var instanceof Node\Expr\Variable
+			&& $propertyFetch->var->name === 'this'
+			&& $propertyFetch->name instanceof Node\Identifier
+			&& $inFunction->getHookedPropertyName() === $propertyFetch->name->toString()
+		) {
+			return [];
+		}
+
 		$errors = [];
 		$reflections = $this->propertyReflectionFinder->findPropertyReflectionsFromNode($propertyFetch, $scope);
 		foreach ($reflections as $propertyReflection) {

tests/PHPStan/Rules/Properties/ReadOnlyByPhpDocPropertyAssignRuleTest.php

@@ -178,4 +178,22 @@ public function testFeature11775(): void
 		]);
 	}
 
+	public function testPropertyHooks(): void
+	{
+		if (PHP_VERSION_ID < 80400) {
+			$this->markTestSkipped('Test requires PHP 8.4.');
+		}
+
+		$this->analyse([__DIR__ . '/data/property-hooks-readonly-by-phpdoc-assign.php'], [
+			[
+				'@readonly property PropertyHooksReadonlyByPhpDocAssign\Foo::$i is assigned outside of the constructor.',
+				15,
+			],
+			[
+				'@readonly property PropertyHooksReadonlyByPhpDocAssign\Foo::$j is assigned outside of the constructor.',
+				17,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Properties/data/property-hooks-readonly-by-phpdoc-assign.php

@@ -0,0 +1,25 @@
+<?php // lint >= 8.4
+
+namespace PropertyHooksReadonlyByPhpDocAssign;
+
+class Foo
+{
+
+	/** @readonly */
+	public int $i {
+		get {
+			return $this->i + 1;
+		}
+		set {
+			$self = new self();
+			$self->i = 1;
+
+			$this->j = 2;
+			$this->i = $value - 1;
+		}
+	}
+
+	/** @readonly */
+	public int $j;
+
+}