Dead Code Detector

Author: ondrejmirtes

build/baseline-7.4.neon

@@ -77,7 +77,3 @@ parameters:
 			message: "#^Class PHPStan\\\\Reflection\\\\BetterReflection\\\\SourceLocator\\\\CachingVisitor has an uninitialized property \\$constantNodes\\. Give it default value or assign it in the constructor\\.$#"
 			count: 1
 			path: ../src/Reflection/BetterReflection/SourceLocator/CachingVisitor.php
-		-
-			message: "#^Class PHPStan\\\\Reflection\\\\ReflectionProvider\\\\SetterReflectionProviderProvider has an uninitialized property \\$reflectionProvider\\. Give it default value or assign it in the constructor\\.$#"
-			count: 1
-			path: ../src/Reflection/ReflectionProvider/SetterReflectionProviderProvider.php

build/phpstan.neon

@@ -4,6 +4,7 @@ includes:
 	- ../vendor/phpstan/phpstan-phpunit/extension.neon
 	- ../vendor/phpstan/phpstan-phpunit/rules.neon
 	- ../vendor/phpstan/phpstan-strict-rules/rules.neon
+	- ../vendor/shipmonk/dead-code-detector/rules.neon
 	- ../conf/bleedingEdge.neon
 	- ../phpstan-baseline.neon
 	- ../phpstan-baseline.php
@@ -71,6 +72,22 @@ parameters:
 		- '#should be contravariant with parameter \$node \(PhpParser\\Node\) of method PHPStan\\Rules\\Rule<PhpParser\\Node>::processNode\(\)$#'
 		- '#Variable property access on PhpParser\\Node#'
 		- '#Test::data[a-zA-Z0-9_]+\(\) return type has no value type specified in iterable type#'
+		-
+			identifier: shipmonk.deadMethod
+			message: '#^Unused .*?Factory::create#' # likely used in DIC
+		-
+			identifier: shipmonk.deadMethod
+			paths:
+				- ../tests/PHPStan/Tests
+				- ../tests/e2e
+		-
+			identifier: shipmonk.deadConstant
+			paths:
+				- ../tests/PHPStan/Fixture
+			reportUnmatched: false # constants on enums, not reported on PHP8-
+		-
+			identifier: shipmonk.deadMethod
+			path: ../src/Reflection/BetterReflection/SourceLocator/FileReadTrapStreamWrapper.php
 		-
 			message: '#Fetching class constant class of deprecated class DeprecatedAnnotations\\DeprecatedFoo.#'
 			path: ../tests/PHPStan/Reflection/Annotations/DeprecatedAnnotationsTest.php

composer.json

@@ -62,6 +62,7 @@
 		"phpstan/phpstan-strict-rules": "^2.0",
 		"phpunit/phpunit": "^9.6",
 		"shipmonk/composer-dependency-analyser": "^1.5",
+		"shipmonk/dead-code-detector": "^0.12.0",
 		"shipmonk/name-collision-detector": "^2.0"
 	},
 	"config": {

composer.lock

@@ -465,7 +465,7 @@ private function analyse(
 			});
 		});
 
-		$process = new ProcessPromise($loop, 'changedFileAnalysis', ProcessHelper::getWorkerCommand(
+		$process = new ProcessPromise($loop, ProcessHelper::getWorkerCommand(
 			$mainScript,
 			'fixer:worker',
 			$projectConfigFile,

src/Command/FixerApplication.php

@@ -15,11 +15,6 @@ public function __construct(private StyleInterface $symfonyStyle)
 	{
 	}
 
-	public function getSymfonyStyle(): StyleInterface
-	{
-		return $this->symfonyStyle;
-	}
-
 	public function title(string $message): void
 	{
 		$this->symfonyStyle->title($message);

src/Command/Symfony/SymfonyStyle.php

@@ -7,7 +7,7 @@ final class BleedingEdgeToggle
 
 	private static bool $bleedingEdge = false;
 
-	public static function isBleedingEdge(): bool
+	public static function isBleedingEdge(): bool // @phpstan-ignore shipmonk.deadMethod (kept for future use)
 	{
 		return self::$bleedingEdge;
 	}

src/DependencyInjection/BleedingEdgeToggle.php

@@ -4,7 +4,6 @@
 
 use Nette\DI\Config\Adapter;
 use Nette\DI\Config\Helpers;
-use Nette\DI\Definitions\Reference;
 use Nette\DI\Definitions\Statement;
 use Nette\DI\InvalidConfigurationException;
 use Nette\Neon\Entity;
@@ -14,7 +13,6 @@
 use PHPStan\File\FileHelper;
 use PHPStan\File\FileReader;
 use function array_values;
-use function array_walk_recursive;
 use function count;
 use function dirname;
 use function implode;
@@ -155,58 +153,6 @@ public function process(array $arr, string $fileKey, string $file): array
 		return $res;
 	}
 
-	/**
-	 * @param mixed[] $data
-	 */
-	public function dump(array $data): string
-	{
-		array_walk_recursive(
-			$data,
-			static function (&$val): void {
-				if (!($val instanceof Statement)) {
-					return;
-				}
-
-				$val = self::statementToEntity($val);
-			},
-		);
-		return "# generated by Nette\n\n" . Neon::encode($data, Neon::BLOCK);
-	}
-
-	private static function statementToEntity(Statement $val): Entity
-	{
-		array_walk_recursive(
-			$val->arguments,
-			static function (&$val): void {
-				if ($val instanceof Statement) {
-					$val = self::statementToEntity($val);
-				} elseif ($val instanceof Reference) {
-					$val = '@' . $val->getValue();
-				}
-			},
-		);
-
-		$entity = $val->getEntity();
-		if ($entity instanceof Reference) {
-			$entity = '@' . $entity->getValue();
-		} elseif (is_array($entity)) {
-			if ($entity[0] instanceof Statement) {
-				return new Entity(
-					Neon::CHAIN,
-					[
-						self::statementToEntity($entity[0]),
-						new Entity('::' . $entity[1], $val->arguments),
-					],
-				);
-			} elseif ($entity[0] instanceof Reference) {
-				$entity = '@' . $entity[0]->getValue() . '::' . $entity[1];
-			} elseif (is_string($entity[0])) {
-				$entity = $entity[0] . '::' . $entity[1];
-			}
-		}
-		return new Entity($entity, $val->arguments);
-	}
-
 	private function createFileHelperByFile(string $file): FileHelper
 	{
 		$dir = dirname($file);

src/DependencyInjection/NeonAdapter.php

@@ -5,7 +5,6 @@
 use PHPStan\ShouldNotHappenException;
 use function array_key_exists;
 use function array_keys;
-use function count;
 use function sha1_file;
 
 final class FileMonitor
@@ -75,7 +74,6 @@ public function getChanges(): FileMonitorResult
 			$newFiles,
 			$changedFiles,
 			$deletedFiles,
-			count($fileHashes),
 		);
 	}
 

src/File/FileMonitor.php

@@ -16,7 +16,6 @@ public function __construct(
 		private array $newFiles,
 		private array $changedFiles,
 		private array $deletedFiles,
-		private int $totalFilesCount,
 	)
 	{
 	}
@@ -36,9 +35,4 @@ public function hasAnyChanges(): bool
 			|| count($this->deletedFiles) > 0;
 	}
 
-	public function getTotalFilesCount(): int
-	{
-		return $this->totalFilesCount;
-	}
-
 }