get rid of instanceof Mixed

Author: staabm

src/Type/Php/ArrayKeyExistsFunctionTypeSpecifyingExtension.php

@@ -119,11 +119,9 @@ public function specifyTypes(
 			);
 		} elseif (
 			$this->phpVersion->throwsValueErrorForInternalFunctions()
-			&& $arrayType instanceof MixedType
+			&& !$arrayType->isArray()->yes()
 		) {
-			$type = TypeCombinator::intersect(
-				new ArrayType(new MixedType(), new MixedType()),
-			);
+			$type = new ArrayType(new MixedType(), new MixedType());
 			$context = $context->negate();
 		} else {
 			$type = new HasOffsetType($keyType);

tests/PHPStan/Analyser/nsrt/bug-2001.php

@@ -16,21 +16,21 @@ public function parseUrl(string $url): string
 			throw new \RuntimeException('Absolute URLs are prohibited for the redirectTo parameter.');
 		}
 
-		assertType('array{scheme?: string, port?: int<0, 65535>, user?: string, pass?: string, path?: string, query?: string, fragment?: string}|false', $parsedUrl);
+		assertType('array{scheme?: string, host?: string, port?: int<0, 65535>, user?: string, pass?: string, path?: string, query?: string, fragment?: string}', $parsedUrl);
 
 		$redirectUrl = $parsedUrl['path'];
 
 		if (array_key_exists('query', $parsedUrl)) {
-			assertType('array{scheme?: string, port?: int<0, 65535>, user?: string, pass?: string, path?: string, query: string, fragment?: string}', $parsedUrl);
+			assertType('array{scheme?: string, host?: string, port?: int<0, 65535>, user?: string, pass?: string, path?: string, query: string, fragment?: string}', $parsedUrl);
 			$redirectUrl .= '?' . $parsedUrl['query'];
 		}
 
 		if (array_key_exists('fragment', $parsedUrl)) {
-			assertType('array{scheme?: string, port?: int<0, 65535>, user?: string, pass?: string, path?: string, query?: string, fragment: string}', $parsedUrl);
+			assertType('array{scheme?: string, host?: string, port?: int<0, 65535>, user?: string, pass?: string, path?: string, query?: string, fragment: string}', $parsedUrl);
 			$redirectUrl .= '#' . $parsedUrl['query'];
 		}
 
-		assertType('array{scheme?: string, port?: int<0, 65535>, user?: string, pass?: string, path?: string, query?: string, fragment?: string}|false', $parsedUrl);
+		assertType('array{scheme?: string, host?: string, port?: int<0, 65535>, user?: string, pass?: string, path?: string, query?: string, fragment?: string}', $parsedUrl);
 
 		return $redirectUrl;
 	}