Remove dead code in ConstantConditionRuleHelper

staabm · ondrejmirtes · commit 88d5b8cf0cb2 · 2024-11-02T14:41:40.000+01:00
diff --git a/src/Rules/Comparison/ConstantConditionRuleHelper.php b/src/Rules/Comparison/ConstantConditionRuleHelper.php
@@ -18,16 +18,6 @@ public function __construct(
 	{
 	}
 
-	public function shouldReportAlwaysTrueByDefault(Expr $expr): bool
-	{
-		return $expr instanceof Expr\BooleanNot
-			|| $expr instanceof Expr\BinaryOp\BooleanOr
-			|| $expr instanceof Expr\BinaryOp\BooleanAnd
-			|| $expr instanceof Expr\Ternary
-			|| $expr instanceof Expr\Isset_
-			|| $expr instanceof Expr\Empty_;
-	}
-
 	public function shouldSkip(Scope $scope, Expr $expr): bool
 	{
 		if (

Original file line number	Diff line number	Diff line change
`@@ -18,16 +18,6 @@ public function __construct(`
`18`	`18`	`{`
`19`	`19`	`}`
`20`	`20`
`21`		`- public function shouldReportAlwaysTrueByDefault(Expr $expr): bool`
`22`		`- {`
`23`		`- return $expr instanceof Expr\BooleanNot`
`24`		`- \|\| $expr instanceof Expr\BinaryOp\BooleanOr`
`25`		`- \|\| $expr instanceof Expr\BinaryOp\BooleanAnd`
`26`		`- \|\| $expr instanceof Expr\Ternary`
`27`		`- \|\| $expr instanceof Expr\Isset_`
`28`		`- \|\| $expr instanceof Expr\Empty_;`
`29`		`- }`
`30`		`-`
`31`	`21`	`public function shouldSkip(Scope $scope, Expr $expr): bool`
`32`	`22`	`{`
`33`	`23`	`if (`