[BCB] Remove ConstantArrayType::removeLast()

Author: ondrejmirtes

UPGRADING.md

@@ -252,6 +252,7 @@ Instead of `PHPStanTestCase::createBroker()`, call `PHPStanTestCase::createRefle
   * Use `getFirstIterable*Type` and `getLastIterable*Type` instead
 * Remove `ConstantArrayType::generalizeToArray()`
 * Remove `ConstantArrayType::findTypeAndMethodName()`, use `findTypeAndMethodNames()` instead
+* Remove `ConstantArrayType::removeLast()`, use [`Type::popArray()`](https://apiref.phpstan.org/2.0.x/PHPStan.Type.Type.html#_popArray) instead
 * Made `TypeUtils` thinner by removing methods:
   * Remove `TypeUtils::getArrays()` and `getAnyArrays()`, use [`Type::getArrays()`](https://apiref.phpstan.org/2.0.x/PHPStan.Type.Type.html#_getArrays) instead
   * Remove `TypeUtils::getConstantArrays()` and `getOldConstantArrays()`, use [`Type::getConstantArrays()`](https://apiref.phpstan.org/2.0.x/PHPStan.Type.Type.html#_getConstantArrays) instead

src/Type/Constant/ConstantArrayType.php

@@ -489,36 +489,6 @@ private function getClassOrObjectAndMethods(): array
 		return [$classOrObject, $method];
 	}
 
-	/** @deprecated Use findTypeAndMethodNames() instead  */
-	public function findTypeAndMethodName(): ?ConstantArrayTypeAndMethod
-	{
-		$callableArray = $this->getClassOrObjectAndMethods();
-		if ($callableArray === []) {
-			return null;
-		}
-
-		[$classOrObject, $method] = $callableArray;
-		if (!$method instanceof ConstantStringType) {
-			return ConstantArrayTypeAndMethod::createUnknown();
-		}
-
-		$type = $classOrObject->getObjectTypeOrClassStringObjectType();
-		if (!$type->isObject()->yes()) {
-			return ConstantArrayTypeAndMethod::createUnknown();
-		}
-
-		$has = $type->hasMethod($method->getValue());
-		if (!$has->no()) {
-			if ($this->isOptionalKey(0) || $this->isOptionalKey(1)) {
-				$has = $has->and(TrinaryLogic::createMaybe());
-			}
-
-			return ConstantArrayTypeAndMethod::createConcrete($type, $method->getValue(), $has);
-		}
-
-		return null;
-	}
-
 	/** @return ConstantArrayTypeAndMethod[] */
 	public function findTypeAndMethodNames(): array
 	{
@@ -1010,12 +980,6 @@ public function isList(): TrinaryLogic
 		return $this->isList;
 	}
 
-	/** @deprecated Use popArray() instead */
-	public function removeLast(): self
-	{
-		return $this->removeLastElements(1);
-	}
-
 	/** @param positive-int $length */
 	private function removeLastElements(int $length): self
 	{