Fix build

Author: ondrejmirtes

conf/config.neon

@@ -975,7 +975,6 @@ services:
 		arguments:
 			checkMissingTypehints: %checkMissingTypehints%
 			checkClassCaseSensitivity: %checkClassCaseSensitivity%
-			absentTypeChecks: %featureToggles.absentTypeChecks%
 
 	-
 		class: PHPStan\Rules\PhpDoc\UnresolvableTypeHelper

src/Rules/PhpDoc/AssertRuleHelper.php

@@ -37,7 +37,6 @@ public function __construct(
 		private ClassNameCheck $classCheck,
 		private MissingTypehintCheck $missingTypehintCheck,
 		private GenericObjectTypeCheck $genericObjectTypeCheck,
-		private bool $absentTypeChecks,
 		private bool $checkClassCaseSensitivity,
 		private bool $checkMissingTypehints,
 	)
@@ -83,11 +82,9 @@ public function check(
 			$assertedExprType = $this->initializerExprTypeResolver->getType($assertedExpr, $context);
 			$assertedExprString = $assert->getParameter()->describe();
 			if ($assertedExprType instanceof ErrorType) {
-				if ($this->absentTypeChecks) {
-					$errors[] = RuleErrorBuilder::message(sprintf('Assert references unknown %s.', $assertedExprString))
-						->identifier('assert.unknownExpr')
-						->build();
-				}
+				$errors[] = RuleErrorBuilder::message(sprintf('Assert references unknown %s.', $assertedExprString))
+					->identifier('assert.unknownExpr')
+					->build();
 				continue;
 			}
 
@@ -99,15 +96,13 @@ public function check(
 				AssertTag::IF_FALSE => '@phpstan-assert-if-false',
 			][$assert->getIf()];
 
-			if ($this->absentTypeChecks) {
-				if ($this->unresolvableTypeHelper->containsUnresolvableType($assertedType)) {
-					$errors[] = RuleErrorBuilder::message(sprintf(
-						'PHPDoc tag %s for %s contains unresolvable type.',
-						$tagName,
-						$assertedExprString,
-					))->identifier('assert.unresolvableType')->build();
-					continue;
-				}
+			if ($this->unresolvableTypeHelper->containsUnresolvableType($assertedType)) {
+				$errors[] = RuleErrorBuilder::message(sprintf(
+					'PHPDoc tag %s for %s contains unresolvable type.',
+					$tagName,
+					$assertedExprString,
+				))->identifier('assert.unresolvableType')->build();
+				continue;
 			}
 
 			$isSuperType = $assertedType->isSuperTypeOf($assertedExprType);
@@ -131,10 +126,6 @@ public function check(
 				}
 			}
 
-			if (!$this->absentTypeChecks) {
-				continue;
-			}
-
 			foreach ($assertedType->getReferencedClasses() as $class) {
 				if (!$this->reflectionProvider->hasClass($class)) {
 					$errors[] = RuleErrorBuilder::message(sprintf(

tests/PHPStan/Rules/PhpDoc/FunctionAssertRuleTest.php

@@ -26,11 +26,10 @@ protected function getRule(): Rule
 			$reflectionProvider,
 			new UnresolvableTypeHelper(),
 			new ClassNameCheck(new ClassCaseSensitivityCheck($reflectionProvider, true), new ClassForbiddenNameCheck(self::getContainer())),
-			new MissingTypehintCheck(true, true, true, true, []),
+			new MissingTypehintCheck(true, []),
 			new GenericObjectTypeCheck(),
 			true,
 			true,
-			true,
 		));
 	}
 

tests/PHPStan/Rules/PhpDoc/MethodAssertRuleTest.php

@@ -26,11 +26,10 @@ protected function getRule(): Rule
 			$reflectionProvider,
 			new UnresolvableTypeHelper(),
 			new ClassNameCheck(new ClassCaseSensitivityCheck($reflectionProvider, true), new ClassForbiddenNameCheck(self::getContainer())),
-			new MissingTypehintCheck(true, true, true, true, []),
+			new MissingTypehintCheck(true, []),
 			new GenericObjectTypeCheck(),
 			true,
 			true,
-			true,
 		));
 	}