Update RegexArrayShapeMatcher.php

staabm · staabm · commit 919abe34d4a7 · 2024-07-14T09:05:33.000+02:00
diff --git a/src/Type/Php/RegexArrayShapeMatcher.php b/src/Type/Php/RegexArrayShapeMatcher.php
@@ -509,6 +509,13 @@ private function getPatternType(Expr $patternExpr, Scope $scope): Type
 		return $scope->getType($patternExpr);
 	}
 
+	/**
+	 * Ignores preg_quote() calls in the concatenation as these are not relevant for array-shape matching.
+	 *
+	 * This assumption only works for the ArrayShapeMatcher therefore it is not implemented for the common case in Scope.
+	 *
+	 * see https://github.com/phpstan/phpstan-src/pull/3233#discussion_r1676938085
+	 */
 	private function resolvePatternConcat(Expr\BinaryOp\Concat $concat, Scope $scope): Type
 	{
 		if (

Original file line number	Diff line number	Diff line change
`@@ -509,6 +509,13 @@ private function getPatternType(Expr $patternExpr, Scope $scope): Type`
`509`	`509`	`return $scope->getType($patternExpr);`
`510`	`510`	`}`
`511`	`511`
	`512`	`+ /**`
	`513`	`+ * Ignores preg_quote() calls in the concatenation as these are not relevant for array-shape matching.`
	`514`	`+ *`
	`515`	`+ * This assumption only works for the ArrayShapeMatcher therefore it is not implemented for the common case in Scope.`
	`516`	`+ *`
	`517`	`+ * see https://github.com/phpstan/phpstan-src/pull/3233#discussion_r1676938085`
	`518`	`+ */`
`512`	`519`	`private function resolvePatternConcat(Expr\BinaryOp\Concat $concat, Scope $scope): Type`
`513`	`520`	`{`
`514`	`521`	`if (`