[BCB] Remove ConstantReflection::getValue()

Author: ondrejmirtes

UPGRADING.md

@@ -241,3 +241,4 @@ Instead of `PHPStanTestCase::createBroker()`, call `PHPStanTestCase::createRefle
 * Remove `PHPStanTestCase::getReflectors()`, use `getReflector()` instead
 * Remove `ClassReflection::getFileNameWithPhpDocs()`, use `getFileName()` instead
 * Remove `AnalysisResult::getInternalErrors()`, use `getInternalErrorObjects()` instead
+* Remove `ConstantReflection::getValue()`, use `getValueExpr()` instead. To get `Type` from `Expr`, use `Scope::getType()` or `InitializerExprTypeResolver::getType()`

src/Reflection/ClassConstantReflection.php

@@ -3,12 +3,10 @@
 namespace PHPStan\Reflection;
 
 use PhpParser\Node\Expr;
-use PHPStan\BetterReflection\NodeCompiler\Exception\UnableToCompileNode;
 use PHPStan\BetterReflection\Reflection\Adapter\ReflectionClassConstant;
 use PHPStan\TrinaryLogic;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypehintHelper;
-use const NAN;
 
 /**
  * @api
@@ -41,19 +39,6 @@ public function getFileName(): ?string
 		return $this->declaringClass->getFileName();
 	}
 
-	/**
-	 * @deprecated Use getValueExpr()
-	 * @return mixed
-	 */
-	public function getValue()
-	{
-		try {
-			return $this->reflection->getValue();
-		} catch (UnableToCompileNode) {
-			return NAN;
-		}
-	}
-
 	public function getValueExpr(): Expr
 	{
 		return $this->reflection->getValueExpression();

src/Reflection/ConstantReflection.php

@@ -8,12 +8,6 @@
 interface ConstantReflection extends ClassMemberReflection, GlobalConstantReflection
 {
 
-	/**
-	 * @deprecated Use getValueExpr()
-	 * @return mixed
-	 */
-	public function getValue();
-
 	public function getValueExpr(): Expr;
 
 }

src/Reflection/Dummy/DummyConstantReflection.php

@@ -51,16 +51,6 @@ public function getName(): string
 		return $this->name;
 	}
 
-	/**
-	 * @deprecated
-	 * @return mixed
-	 */
-	public function getValue()
-	{
-		// so that Scope::getTypeFromValue() returns mixed
-		return new stdClass();
-	}
-
 	public function getValueType(): Type
 	{
 		return new MixedType();