[BCB] Remove FunctionReflection::isFinal()

Author: ondrejmirtes

UPGRADING.md

@@ -277,3 +277,4 @@ Instead of `PHPStanTestCase::createBroker()`, call `PHPStanTestCase::createRefle
 * Parameter `$nextAutoIndexes` in `ConstantArrayType` constructor can only be `non-empty-list<int>`, no longer int
 * Remove `ConstantType` interface, use [`Type::isConstantValue()`](https://apiref.phpstan.org/2.0.x/PHPStan.Type.Type.html#_isConstantValue) instead
 * `acceptsNamedArguments()` in `FunctionReflection`, `ExtendedMethodReflection` and `CallableParametersAcceptor` interfaces returns `TrinaryLogic` instead of `bool`
+* Remove `FunctionReflection::isFinal()`

src/Analyser/MutatingScope.php

@@ -3075,7 +3075,6 @@ public function enterFunction(
 		?string $deprecatedDescription,
 		bool $isDeprecated,
 		bool $isInternal,
-		bool $isFinal,
 		?bool $isPure = null,
 		bool $acceptsNamedArguments = true,
 		?Assertions $asserts = null,
@@ -3099,7 +3098,6 @@ public function enterFunction(
 				$deprecatedDescription,
 				$isDeprecated,
 				$isInternal,
-				$isFinal,
 				$isPure,
 				$acceptsNamedArguments,
 				$asserts ?? Assertions::createEmpty(),

src/Analyser/NodeScopeResolver.php

@@ -513,7 +513,7 @@ private function processStmtNode(
 			$throwPoints = [];
 			$impurePoints = [];
 			$this->processAttributeGroups($stmt, $stmt->attrGroups, $scope, $nodeCallback);
-			[$templateTypeMap, $phpDocParameterTypes, $phpDocImmediatelyInvokedCallableParameters, $phpDocClosureThisTypeParameters, $phpDocReturnType, $phpDocThrowType, $deprecatedDescription, $isDeprecated, $isInternal, $isFinal, $isPure, $acceptsNamedArguments, , $phpDocComment, $asserts,, $phpDocParameterOutTypes] = $this->getPhpDocs($scope, $stmt);
+			[$templateTypeMap, $phpDocParameterTypes, $phpDocImmediatelyInvokedCallableParameters, $phpDocClosureThisTypeParameters, $phpDocReturnType, $phpDocThrowType, $deprecatedDescription, $isDeprecated, $isInternal, , $isPure, $acceptsNamedArguments, , $phpDocComment, $asserts,, $phpDocParameterOutTypes] = $this->getPhpDocs($scope, $stmt);
 
 			foreach ($stmt->params as $param) {
 				$this->processParamNode($stmt, $param, $scope, $nodeCallback);
@@ -532,7 +532,6 @@ private function processStmtNode(
 				$deprecatedDescription,
 				$isDeprecated,
 				$isInternal,
-				$isFinal,
 				$isPure,
 				$acceptsNamedArguments,
 				$asserts,

src/Reflection/FunctionReflection.php

@@ -34,8 +34,6 @@ public function isDeprecated(): TrinaryLogic;
 
 	public function getDeprecatedDescription(): ?string;
 
-	public function isFinal(): TrinaryLogic;
-
 	public function isInternal(): TrinaryLogic;
 
 	public function getThrowType(): ?Type;

src/Reflection/Native/NativeFunctionReflection.php

@@ -88,11 +88,6 @@ public function isInternal(): TrinaryLogic
 		return TrinaryLogic::createNo();
 	}
 
-	public function isFinal(): TrinaryLogic
-	{
-		return TrinaryLogic::createNo();
-	}
-
 	public function hasSideEffects(): TrinaryLogic
 	{
 		if ($this->isVoid()) {

src/Reflection/Php/ExitFunctionReflection.php

@@ -97,11 +97,6 @@ public function getDeprecatedDescription(): ?string
 		return null;
 	}
 
-	public function isFinal(): TrinaryLogic
-	{
-		return TrinaryLogic::createNo();
-	}
-
 	public function isInternal(): TrinaryLogic
 	{
 		return TrinaryLogic::createYes();

src/Reflection/Php/PhpFunctionFromParserNodeReflection.php

@@ -58,7 +58,6 @@ public function __construct(
 		private ?string $deprecatedDescription,
 		private bool $isDeprecated,
 		private bool $isInternal,
-		private bool $isFinal,
 		protected ?bool $isPure,
 		private bool $acceptsNamedArguments,
 		private Assertions $assertions,
@@ -235,24 +234,6 @@ public function isInternal(): TrinaryLogic
 		return TrinaryLogic::createFromBoolean($this->isInternal);
 	}
 
-	public function isFinal(): TrinaryLogic
-	{
-		$finalMethod = false;
-		if ($this->functionLike instanceof ClassMethod) {
-			$finalMethod = $this->functionLike->isFinal();
-		}
-		return TrinaryLogic::createFromBoolean($finalMethod || $this->isFinal);
-	}
-
-	public function isFinalByKeyword(): TrinaryLogic
-	{
-		$finalMethod = false;
-		if ($this->functionLike instanceof ClassMethod) {
-			$finalMethod = $this->functionLike->isFinal();
-		}
-		return TrinaryLogic::createFromBoolean($finalMethod);
-	}
-
 	public function getThrowType(): ?Type
 	{
 		return $this->throwType;

src/Reflection/Php/PhpFunctionReflection.php

@@ -249,11 +249,6 @@ public function isInternal(): TrinaryLogic
 		return TrinaryLogic::createFromBoolean($this->isInternal);
 	}
 
-	public function isFinal(): TrinaryLogic
-	{
-		return TrinaryLogic::createFromBoolean($this->isFinal);
-	}
-
 	public function getThrowType(): ?Type
 	{
 		return $this->phpDocThrowType;

src/Reflection/Php/PhpMethodFromParserNodeReflection.php

@@ -38,7 +38,7 @@ final class PhpMethodFromParserNodeReflection extends PhpFunctionFromParserNodeR
 	 */
 	public function __construct(
 		private ClassReflection $declaringClass,
-		ClassMethod $classMethod,
+		private ClassMethod $classMethod,
 		string $fileName,
 		TemplateTypeMap $templateTypeMap,
 		array $realParameterTypes,
@@ -50,7 +50,7 @@ public function __construct(
 		?string $deprecatedDescription,
 		bool $isDeprecated,
 		bool $isInternal,
-		bool $isFinal,
+		private bool $isFinal,
 		?bool $isPure,
 		bool $acceptsNamedArguments,
 		Assertions $assertions,
@@ -107,7 +107,6 @@ public function __construct(
 			$deprecatedDescription,
 			$isDeprecated,
 			$isInternal,
-			$isFinal || $classMethod->isFinal(),
 			$isPure,
 			$acceptsNamedArguments,
 			$assertions,
@@ -154,6 +153,16 @@ public function isPublic(): bool
 		return $this->getClassMethod()->isPublic();
 	}
 
+	public function isFinal(): TrinaryLogic
+	{
+		return TrinaryLogic::createFromBoolean($this->classMethod->isFinal() || $this->isFinal);
+	}
+
+	public function isFinalByKeyword(): TrinaryLogic
+	{
+		return TrinaryLogic::createFromBoolean($this->classMethod->isFinal());
+	}
+
 	public function isBuiltin(): bool
 	{
 		return false;

tests/PHPStan/Reflection/Annotations/FinalAnnotationsTest.php

@@ -4,7 +4,6 @@
 
 use FinalAnnotations\FinalFoo;
 use FinalAnnotations\Foo;
-use PhpParser\Node\Name;
 use PHPStan\Analyser\Scope;
 use PHPStan\Testing\PHPStanTestCase;
 
@@ -58,14 +57,4 @@ public function testFinalAnnotations(bool $final, string $className, array $fina
 		}
 	}
 
-	public function testFinalUserFunctions(): void
-	{
-		require_once __DIR__ . '/data/annotations-final.php';
-
-		$reflectionProvider = $this->createReflectionProvider();
-
-		$this->assertFalse($reflectionProvider->getFunction(new Name\FullyQualified('FinalAnnotations\foo'), null)->isFinal()->yes());
-		$this->assertTrue($reflectionProvider->getFunction(new Name\FullyQualified('FinalAnnotations\finalFoo'), null)->isFinal()->yes());
-	}
-
 }