[BE] Detect duplicate stub classes and functions

Author: ondrejmirtes

changelog-2.0.md

@@ -51,7 +51,6 @@ Bleeding edge (TODO move to other sections)
     * Report `instanceof` of classes covered by backward compatibility promise but where the assumption might change (https://github.com/phpstan/phpstan-src/commit/996bc69fa977aa64f601bd82b8a0ae39be0cbeef)
 * Add `@readonly` rule that disallows default values ([#1391](https://github.com/phpstan/phpstan-src/pull/1391)), thanks @herndlm!
 * MissingMagicSerializationMethodsRule ([#1711](https://github.com/phpstan/phpstan-src/pull/1711)), #7482, thanks @staabm!
-* Stub files validation - detect duplicate classes and functions (https://github.com/phpstan/phpstan-src/commit/ddf8d5c3859c2c75c20f525a0e2ca8b99032373a, https://github.com/phpstan/phpstan-src/commit/17e4b74335e5235d7cd6708eb687a774a0eeead4)
 * Change `curl_setopt` function signature based on 2nd arg ([#1719](https://github.com/phpstan/phpstan-src/pull/1719)), thanks @staabm!
 * Empty `skipCheckGenericClasses` (https://github.com/phpstan/phpstan-src/commit/28c2c79b16cac6ba6b01f1b4d211541dd49d8a77)
 * Validate inline PHPDoc `@var` tag type against native type (https://github.com/phpstan/phpstan-src/commit/a69e3bc2f1e87f6da1e65d7935f1cc36bd5c42fe)
@@ -128,6 +127,7 @@ Improvements 🔧
 * Stricter ++/-- operator check ([#3255](https://github.com/phpstan/phpstan-src/pull/3255)), thanks @schlndh!
 * Check mixed in binary operator ([#3231](https://github.com/phpstan/phpstan-src/pull/3231)), #7538, #10440, thanks @schlndh!
 * Check mixed in unary operator ([#3253](https://github.com/phpstan/phpstan-src/pull/3253)), thanks @schlndh!
+* Stub files validation - detect duplicate classes and functions (https://github.com/phpstan/phpstan-src/commit/ddf8d5c3859c2c75c20f525a0e2ca8b99032373a, https://github.com/phpstan/phpstan-src/commit/17e4b74335e5235d7cd6708eb687a774a0eeead4)
 
 Bugfixes 🐛
 =====================

conf/bleedingEdge.neon

@@ -22,7 +22,6 @@ parameters:
 		nullContextForVoidReturningFunctions: true
 		unescapeStrings: true
 		alwaysCheckTooWideReturnTypeFinalMethods: true
-		duplicateStubs: true
 		logicalXor: true
 		betterNoop: true
 		alwaysTrueAlwaysReported: true

conf/config.neon

@@ -43,7 +43,6 @@ parameters:
 		nullContextForVoidReturningFunctions: false
 		unescapeStrings: false
 		alwaysCheckTooWideReturnTypeFinalMethods: false
-		duplicateStubs: false
 		logicalXor: false
 		betterNoop: false
 		alwaysTrueAlwaysReported: false
@@ -426,8 +425,6 @@ services:
 
 	-
 		class: PHPStan\PhpDoc\StubValidator
-		arguments:
-			duplicateStubs: %featureToggles.duplicateStubs%
 
 	-
 		class: PHPStan\PhpDoc\SocketSelectStubFilesExtension

conf/parametersSchema.neon

@@ -49,7 +49,6 @@ parametersSchema:
 		nullContextForVoidReturningFunctions: bool()
 		unescapeStrings: bool()
 		alwaysCheckTooWideReturnTypeFinalMethods: bool()
-		duplicateStubs: bool()
 		logicalXor: bool()
 		betterNoop: bool()
 		alwaysTrueAlwaysReported: bool()

src/PhpDoc/StubValidator.php

@@ -95,7 +95,6 @@ final class StubValidator
 
 	public function __construct(
 		private DerivativeContainerFactory $derivativeContainerFactory,
-		private bool $duplicateStubs,
 	)
 	{
 	}
@@ -188,6 +187,8 @@ private function getRuleRegistry(Container $container): RuleRegistry
 		$mixinCheck = $container->getByType(MixinCheck::class);
 		$methodTagCheck = new MethodTagCheck($reflectionProvider, $classNameCheck, $genericObjectTypeCheck, $missingTypehintCheck, $unresolvableTypeHelper, true, true);
 		$propertyTagCheck = new PropertyTagCheck($reflectionProvider, $classNameCheck, $genericObjectTypeCheck, $missingTypehintCheck, $unresolvableTypeHelper, true, true);
+		$reflector = $container->getService('stubReflector');
+		$relativePathHelper = $container->getService('simpleRelativePathHelper');
 
 		$rules = [
 			// level 0
@@ -247,14 +248,11 @@ private function getRuleRegistry(Container $container): RuleRegistry
 			new MissingMethodReturnTypehintRule($missingTypehintCheck),
 			new MissingPropertyTypehintRule($missingTypehintCheck),
 			new MissingMethodSelfOutTypeRule($missingTypehintCheck),
-		];
 
-		if ($this->duplicateStubs) {
-			$reflector = $container->getService('stubReflector');
-			$relativePathHelper = $container->getService('simpleRelativePathHelper');
-			$rules[] = new DuplicateClassDeclarationRule($reflector, $relativePathHelper);
-			$rules[] = new DuplicateFunctionDeclarationRule($reflector, $relativePathHelper);
-		}
+			// duplicate stubs
+			new DuplicateClassDeclarationRule($reflector, $relativePathHelper),
+			new DuplicateFunctionDeclarationRule($reflector, $relativePathHelper),
+		];
 
 		return new DirectRuleRegistry($rules);
 	}