Fixes

ondrejmirtes · ondrejmirtes · commit 9c177958fc2e · 2024-09-04T15:30:30.000+02:00
diff --git a/src/Analyser/NodeScopeResolver.php b/src/Analyser/NodeScopeResolver.php
@@ -494,7 +494,7 @@ private function processStmtNode(
 				$nodeCallback($declare->value, $scope);
 				if (
 					$declare->key->name !== 'strict_types'
-					|| !($declare->value instanceof Node\Scalar\LNumber)
+					|| !($declare->value instanceof Node\Scalar\Int_)
 					|| $declare->value->value !== 1
 				) {
 					continue;
@@ -5298,7 +5298,7 @@ static function (): void {
 				$impurePoints = array_merge($impurePoints, $valueResult->getImpurePoints());
 
 				if ($arrayItem->key === null) {
-					$dimExpr = new Node\Scalar\LNumber($i);
+					$dimExpr = new Node\Scalar\Int_($i);
 				} else {
 					$dimExpr = $arrayItem->key;
 				}
diff --git a/src/Analyser/StatementResult.php b/src/Analyser/StatementResult.php
@@ -2,7 +2,7 @@
 
 namespace PHPStan\Analyser;
 
-use PhpParser\Node\Scalar\LNumber;
+use PhpParser\Node\Scalar\Int_;
 use PhpParser\Node\Stmt;
 
 /**
@@ -58,7 +58,7 @@ public function filterOutLoopExitPoints(): self
 			}
 
 			$num = $statement->num;
-			if (!$num instanceof LNumber) {
+			if (!$num instanceof Int_) {
 				return new self($this->scope, $this->hasYield, false, $this->exitPoints, $this->throwPoints, $this->impurePoints);
 			}
 
@@ -99,7 +99,7 @@ public function getExitPointsByType(string $stmtClass): array
 				continue;
 			}
 
-			if (!$value instanceof LNumber) {
+			if (!$value instanceof Int_) {
 				$exitPoints[] = $exitPoint;
 				continue;
 			}
@@ -130,7 +130,7 @@ public function getExitPointsForOuterLoop(): array
 			if ($statement->num === null) {
 				continue;
 			}
-			if (!$statement->num instanceof LNumber) {
+			if (!$statement->num instanceof Int_) {
 				continue;
 			}
 			$value = $statement->num->value;
@@ -140,7 +140,7 @@ public function getExitPointsForOuterLoop(): array
 
 			$newNode = null;
 			if ($value > 2) {
-				$newNode = new LNumber($value - 1);
+				$newNode = new Int_($value - 1);
 			}
 			if ($statement instanceof Stmt\Continue_) {
 				$newStatement = new Stmt\Continue_($newNode);
diff --git a/src/Parser/RemoveUnusedCodeByPhpVersionIdVisitor.php b/src/Parser/RemoveUnusedCodeByPhpVersionIdVisitor.php
@@ -77,15 +77,15 @@ public function enterNode(Node $node): ?Node
 	private function getOperands(Node\Expr $left, Node\Expr $right): ?array
 	{
 		if (
-			$left instanceof Node\Scalar\LNumber
+			$left instanceof Node\Scalar\Int_
 			&& $right instanceof Node\Expr\ConstFetch
 			&& $right->name->toString() === 'PHP_VERSION_ID'
 		) {
 			return [(new PhpVersion($left->value))->getVersionString(), $this->phpVersionString];
 		}
 
 		if (
-			$right instanceof Node\Scalar\LNumber
+			$right instanceof Node\Scalar\Int_
 			&& $left instanceof Node\Expr\ConstFetch
 			&& $left->name->toString() === 'PHP_VERSION_ID'
 		) {
diff --git a/src/Reflection/InitializerExprTypeResolver.php b/src/Reflection/InitializerExprTypeResolver.php
@@ -2044,7 +2044,7 @@ public function getUnaryMinusType(Expr $expr, callable $getTypeCallback): Type
 		}
 
 		if ($type instanceof IntegerRangeType) {
-			return $getTypeCallback(new Expr\BinaryOp\Mul($expr, new LNumber(-1)));
+			return $getTypeCallback(new Expr\BinaryOp\Mul($expr, new Int_(-1)));
 		}
 
 		return $type;
diff --git a/src/Rules/Arrays/ArrayDestructuringRule.php b/src/Rules/Arrays/ArrayDestructuringRule.php
@@ -85,7 +85,7 @@ private function getErrors(Scope $scope, Node\Expr\List_ $var, Expr $expr): arra
 			$keyExpr = null;
 			if ($item->key === null) {
 				$keyType = new ConstantIntegerType($i);
-				$keyExpr = new Node\Scalar\LNumber($i);
+				$keyExpr = new Node\Scalar\Int_($i);
 			} else {
 				$keyType = $scope->getType($item->key);
 				$keyExpr = new TypeExpr($keyType);
diff --git a/src/Rules/Classes/EnumSanityRule.php b/src/Rules/Classes/EnumSanityRule.php
@@ -143,7 +143,7 @@ public function processNode(Node $node, Scope $scope): array
 			}
 			$caseName = $stmt->name->name;
 
-			if ($stmt->expr instanceof Node\Scalar\LNumber || $stmt->expr instanceof Node\Scalar\String_) {
+			if ($stmt->expr instanceof Node\Scalar\Int_ || $stmt->expr instanceof Node\Scalar\String_) {
 				if ($enumNode->scalarType === null) {
 					$errors[] = RuleErrorBuilder::message(sprintf(
 						'Enum %s is not backed, but case %s has value %s.',
diff --git a/src/Rules/Comparison/DoWhileLoopConstantConditionRule.php b/src/Rules/Comparison/DoWhileLoopConstantConditionRule.php
@@ -3,7 +3,7 @@
 namespace PHPStan\Rules\Comparison;
 
 use PhpParser\Node;
-use PhpParser\Node\Scalar\LNumber;
+use PhpParser\Node\Scalar\Int_;
 use PhpParser\Node\Stmt\Break_;
 use PhpParser\Node\Stmt\Continue_;
 use PHPStan\Analyser\Scope;
@@ -47,7 +47,7 @@ public function processNode(Node $node, Scope $scope): array
 					if ($statement->num === null) {
 						continue;
 					}
-					if (!$statement->num instanceof LNumber) {
+					if (!$statement->num instanceof Int_) {
 						continue;
 					}
 					$value = $statement->num->value;
diff --git a/src/Rules/Comparison/WhileLoopAlwaysTrueConditionRule.php b/src/Rules/Comparison/WhileLoopAlwaysTrueConditionRule.php
@@ -3,7 +3,7 @@
 namespace PHPStan\Rules\Comparison;
 
 use PhpParser\Node;
-use PhpParser\Node\Scalar\LNumber;
+use PhpParser\Node\Scalar\Int_;
 use PhpParser\Node\Stmt\Break_;
 use PhpParser\Node\Stmt\Continue_;
 use PHPStan\Analyser\Scope;
@@ -46,7 +46,7 @@ public function processNode(
 			if ($statement->num === null) {
 				continue;
 			}
-			if (!$statement->num instanceof LNumber) {
+			if (!$statement->num instanceof Int_) {
 				continue;
 			}
 			$value = $statement->num->value;
diff --git a/src/Rules/Keywords/ContinueBreakInLoopRule.php b/src/Rules/Keywords/ContinueBreakInLoopRule.php
@@ -28,7 +28,7 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		if (!$node->num instanceof Node\Scalar\LNumber) {
+		if (!$node->num instanceof Node\Scalar\Int_) {
 			$value = 1;
 		} else {
 			$value = $node->num->value;
diff --git a/src/Rules/Keywords/DeclareStrictTypesRule.php b/src/Rules/Keywords/DeclareStrictTypesRule.php
@@ -40,7 +40,7 @@ public function processNode(Node $node, Scope $scope): array
 			}
 
 			if (
-				!$declare->value instanceof Node\Scalar\LNumber
+				!$declare->value instanceof Node\Scalar\Int_
 				|| !in_array($declare->value->value, [0, 1], true)
 			) {
 				return [
diff --git a/src/Rules/PhpDoc/VarTagTypeRuleHelper.php b/src/Rules/PhpDoc/VarTagTypeRuleHelper.php
@@ -53,7 +53,7 @@ public function checkVarType(Scope $scope, Node\Expr $var, Node\Expr $expr, arra
 					continue;
 				}
 				if ($arrayItem->key === null) {
-					$dimExpr = new Node\Scalar\LNumber($i);
+					$dimExpr = new Node\Scalar\Int_($i);
 				} else {
 					$dimExpr = $arrayItem->key;
 				}
diff --git a/src/Type/Php/ArraySumFunctionDynamicReturnTypeExtension.php b/src/Type/Php/ArraySumFunctionDynamicReturnTypeExtension.php
@@ -5,7 +5,7 @@
 use PhpParser\Node\Expr\BinaryOp\Mul;
 use PhpParser\Node\Expr\BinaryOp\Plus;
 use PhpParser\Node\Expr\FuncCall;
-use PhpParser\Node\Scalar\LNumber;
+use PhpParser\Node\Scalar\Int_;
 use PHPStan\Analyser\Scope;
 use PHPStan\Node\Expr\TypeExpr;
 use PHPStan\Reflection\FunctionReflection;
@@ -35,7 +35,7 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
 
 		if (count($argType->getConstantArrays()) > 0) {
 			foreach ($argType->getConstantArrays() as $constantArray) {
-				$node = new LNumber(0);
+				$node = new Int_(0);
 
 				foreach ($constantArray->getValueTypes() as $i => $type) {
 					if ($constantArray->isOptionalKey($i)) {

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace PHPStan\Analyser;`
`4`	`4`
`5`		`-use PhpParser\Node\Scalar\LNumber;`
	`5`	`+use PhpParser\Node\Scalar\Int_;`
`6`	`6`	`use PhpParser\Node\Stmt;`
`7`	`7`
`8`	`8`	`/**`
`@@ -58,7 +58,7 @@ public function filterOutLoopExitPoints(): self`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`$num = $statement->num;`
`61`		`- if (!$num instanceof LNumber) {`
	`61`	`+ if (!$num instanceof Int_) {`
`62`	`62`	`return new self($this->scope, $this->hasYield, false, $this->exitPoints, $this->throwPoints, $this->impurePoints);`
`63`	`63`	`}`
`64`	`64`
`@@ -99,7 +99,7 @@ public function getExitPointsByType(string $stmtClass): array`
`99`	`99`	`continue;`
`100`	`100`	`}`
`101`	`101`
`102`		`- if (!$value instanceof LNumber) {`
	`102`	`+ if (!$value instanceof Int_) {`
`103`	`103`	`$exitPoints[] = $exitPoint;`
`104`	`104`	`continue;`
`105`	`105`	`}`
`@@ -130,7 +130,7 @@ public function getExitPointsForOuterLoop(): array`
`130`	`130`	`if ($statement->num === null) {`
`131`	`131`	`continue;`
`132`	`132`	`}`
`133`		`- if (!$statement->num instanceof LNumber) {`
	`133`	`+ if (!$statement->num instanceof Int_) {`
`134`	`134`	`continue;`
`135`	`135`	`}`
`136`	`136`	`$value = $statement->num->value;`
`@@ -140,7 +140,7 @@ public function getExitPointsForOuterLoop(): array`
`140`	`140`
`141`	`141`	`$newNode = null;`
`142`	`142`	`if ($value > 2) {`
`143`		`- $newNode = new LNumber($value - 1);`
	`143`	`+ $newNode = new Int_($value - 1);`
`144`	`144`	`}`
`145`	`145`	`if ($statement instanceof Stmt\Continue_) {`
`146`	`146`	`$newStatement = new Stmt\Continue_($newNode);`
Original file line number	Diff line number	Diff line change
`@@ -2044,7 +2044,7 @@ public function getUnaryMinusType(Expr $expr, callable $getTypeCallback): Type`
`2044`	`2044`	`}`
`2045`	`2045`
`2046`	`2046`	`if ($type instanceof IntegerRangeType) {`
`2047`		`- return $getTypeCallback(new Expr\BinaryOp\Mul($expr, new LNumber(-1)));`
	`2047`	`+ return $getTypeCallback(new Expr\BinaryOp\Mul($expr, new Int_(-1)));`
`2048`	`2048`	`}`
`2049`	`2049`
`2050`	`2050`	`return $type;`
Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ public function processNode(Node $node, Scope $scope): array`
`143`	`143`	`}`
`144`	`144`	`$caseName = $stmt->name->name;`
`145`	`145`
`146`		`- if ($stmt->expr instanceof Node\Scalar\LNumber \|\| $stmt->expr instanceof Node\Scalar\String_) {`
	`146`	`+ if ($stmt->expr instanceof Node\Scalar\Int_ \|\| $stmt->expr instanceof Node\Scalar\String_) {`
`147`	`147`	`if ($enumNode->scalarType === null) {`
`148`	`148`	`$errors[] = RuleErrorBuilder::message(sprintf(`
`149`	`149`	`'Enum %s is not backed, but case %s has value %s.',`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ public function processNode(Node $node, Scope $scope): array`
`28`	`28`	`return [];`
`29`	`29`	`}`
`30`	`30`
`31`		`- if (!$node->num instanceof Node\Scalar\LNumber) {`
	`31`	`+ if (!$node->num instanceof Node\Scalar\Int_) {`
`32`	`32`	`$value = 1;`
`33`	`33`	`} else {`
`34`	`34`	`$value = $node->num->value;`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ public function processNode(Node $node, Scope $scope): array`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`if (`
`43`		`- !$declare->value instanceof Node\Scalar\LNumber`
	`43`	`+ !$declare->value instanceof Node\Scalar\Int_`
`44`	`44`	`\|\| !in_array($declare->value->value, [0, 1], true)`
`45`	`45`	`) {`
`46`	`46`	`return [`