Add tests

Author: VincentLanglet

tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeFunctionCallRuleTest.php

@@ -1202,7 +1202,16 @@ public function testBug13799(): void
 	public function testBug13023(): void
 	{
 		$this->treatPhpDocTypesAsCertain = true;
-		$this->analyse([__DIR__ . '/data/bug-13023.php'], []);
+		$this->analyse([__DIR__ . '/data/bug-13023.php'], [
+			[
+				'Call to function is_int() with 0 will always evaluate to true.',
+				198,
+			],
+			[
+				'Call to function is_int() with int<1, max> will always evaluate to true.',
+				198,
+			],
+		]);
 	}
 
 	#[RequiresPhp('>= 8.1')]

tests/PHPStan/Rules/Comparison/NumberComparisonOperatorsConstantConditionRuleTest.php

@@ -288,6 +288,11 @@ public function testBug13874(): void
 		$this->analyse([__DIR__ . '/data/bug-13874.php'], []);
 	}
 
+	public function testBug13023(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-13023.php'], []);
+	}
+
 	public function testBug12163(): void
 	{
 		$this->analyse([__DIR__ . '/../../Analyser/nsrt/bug-12163.php'], [

tests/PHPStan/Rules/Comparison/data/bug-13023.php

@@ -170,21 +170,39 @@ public function getRandom(): int
 class SomeClass11
 {
 	use MyTrait6;
+
+	/** @return non-empty-array */
+	public function getBar(): array
+	{
+		return ['foo'];
+	}
 }
 
-trait MyTrait6
+class SomeClass12
 {
+	use MyTrait6;
+
+	/** @return array{} */
 	public function getBar(): array
 	{
 		return [];
 	}
+}
+
+trait MyTrait6
+{
+	abstract public function getBar(): array;
 
 	public function getRandom(): int
 	{
 		if (!\is_int(count($this->getBar()))) {
 			return 1;
 		}
 
+		if (count($this->getBar()) > 0) {
+			return 1;
+		}
+
 		return 0;
 	}
 }