abstract final

Author: staabm

src/Rules/Properties/PropertyInClassRule.php

@@ -118,6 +118,15 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		if ($classReflection->isAbstract() && $node->isAbstract()) {
+			if ($node->isFinal()) {
+				return [
+					RuleErrorBuilder::message('Property cannot be both abstract and final.')
+						->nonIgnorable()
+						->identifier('property.abstractFinal')
+						->build(),
+				];
+			}
+
 			foreach ($node->getHooks() as $hook) {
 				if (!$hook->isFinal()) {
 					continue;
@@ -126,7 +135,7 @@ public function processNode(Node $node, Scope $scope): array
 				return [
 					RuleErrorBuilder::message('Property cannot be both abstract and final.')
 						->nonIgnorable()
-						->identifier('property.finalPrivate')
+						->identifier('property.abstractFinal')
 						->build(),
 				];
 			}

tests/PHPStan/Rules/Properties/PropertyInClassRuleTest.php

@@ -242,6 +242,10 @@ public function testPhp84AndAbstractFinalHookedProperties(): void
 				'Property cannot be both abstract and final.',
 				7,
 			],
+			[
+				'Property cannot be both abstract and final.',
+				11,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Properties/data/abstract-final-property-hook.php

@@ -7,4 +7,8 @@ abstract class User
 	abstract public string $foo {
 		final get;
 	}
+
+	final abstract public string $bar {
+		get;
+	}
 }