Skip to content

Commit aba6f49

Browse files
committed
fix: rename tests files and add namespace according to review
1 parent 3182d3e commit aba6f49

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

tests/PHPStan/Rules/Variables/DefinedVariableRuleTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1169,14 +1169,14 @@ public function testBug8719(): void
11691169
$this->analyse([__DIR__ . '/data/bug-8719.php'], []);
11701170
}
11711171

1172-
public function testDynamicVariableInsideIsset(): void
1172+
public function testBug13353(): void
11731173
{
11741174
$this->cliArgumentsVariablesRegistered = true;
11751175
$this->polluteScopeWithLoopInitialAssignments = true;
11761176
$this->checkMaybeUndefinedVariables = true;
11771177
$this->polluteScopeWithAlwaysIterableForeach = true;
11781178

1179-
$this->analyse([__DIR__ . '/data/dynamic-variable-inside-isset.php'], [
1179+
$this->analyse([__DIR__ . '/data/bug-13353.php'], [
11801180
[
11811181
'Variable $bar might not be defined.',
11821182
9,

tests/PHPStan/Rules/Variables/data/dynamic-variable-inside-isset.php renamed to tests/PHPStan/Rules/Variables/data/bug-13353.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
<?php declare(strict_types = 1);
22

3+
namespace Bug13353;
4+
35
$foo = 'bar';
46

57
if (!isset($$foo)) {

0 commit comments

Comments
 (0)