Useful getPropertyReflection() shortcut in property hook virtual nodes

Author: ondrejmirtes

src/Analyser/NodeScopeResolver.php

@@ -4792,7 +4792,19 @@ private function processPropertyHooks(
 			if (!$hookReflection instanceof PhpMethodFromParserNodeReflection) {
 				throw new ShouldNotHappenException();
 			}
-			$nodeCallback(new InPropertyHookNode($classReflection, $hookReflection, $hook), $hookScope);
+
+			if (!$classReflection->hasNativeProperty($propertyName)) {
+				throw new ShouldNotHappenException();
+			}
+
+			$propertyReflection = $classReflection->getNativeProperty($propertyName);
+
+			$nodeCallback(new InPropertyHookNode(
+				$classReflection,
+				$hookReflection,
+				$propertyReflection,
+				$hook,
+			), $hookScope);
 
 			if ($hook->body instanceof Expr) {
 				$this->processExprNode($stmt, $hook->body, $hookScope, $nodeCallback, ExpressionContext::createTopLevel());
@@ -4838,6 +4850,7 @@ private function processPropertyHooks(
 					array_merge($statementResult->getImpurePoints(), $methodImpurePoints),
 					$classReflection,
 					$hookReflection,
+					$propertyReflection,
 				), $hookScope);
 			}
 

src/Node/InPropertyHookNode.php

@@ -6,6 +6,7 @@
 use PhpParser\NodeAbstract;
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\Php\PhpMethodFromParserNodeReflection;
+use PHPStan\Reflection\Php\PhpPropertyReflection;
 
 /**
  * @api
@@ -16,6 +17,7 @@ final class InPropertyHookNode extends NodeAbstract implements VirtualNode
 	public function __construct(
 		private ClassReflection $classReflection,
 		private PhpMethodFromParserNodeReflection $hookReflection,
+		private PhpPropertyReflection $propertyReflection,
 		private Node\PropertyHook $originalNode,
 	)
 	{
@@ -32,6 +34,11 @@ public function getHookReflection(): PhpMethodFromParserNodeReflection
 		return $this->hookReflection;
 	}
 
+	public function getPropertyReflection(): PhpPropertyReflection
+	{
+		return $this->propertyReflection;
+	}
+
 	public function getOriginalNode(): Node\PropertyHook
 	{
 		return $this->originalNode;

src/Node/PropertyHookReturnStatementsNode.php

@@ -8,6 +8,7 @@
 use PHPStan\Analyser\StatementResult;
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\Php\PhpMethodFromParserNodeReflection;
+use PHPStan\Reflection\Php\PhpPropertyReflection;
 
 /**
  * @api
@@ -28,6 +29,7 @@ public function __construct(
 		private array $impurePoints,
 		private ClassReflection $classReflection,
 		private PhpMethodFromParserNodeReflection $hookReflection,
+		private PhpPropertyReflection $propertyReflection,
 	)
 	{
 		parent::__construct($hook->getAttributes());
@@ -88,6 +90,11 @@ public function getHookReflection(): PhpMethodFromParserNodeReflection
 		return $this->hookReflection;
 	}
 
+	public function getPropertyReflection(): PhpPropertyReflection
+	{
+		return $this->propertyReflection;
+	}
+
 	public function getType(): string
 	{
 		return 'PHPStan_Node_PropertyHookReturnStatementsNode';

src/Rules/Properties/SetNonVirtualPropertyHookAssignRule.php

@@ -37,11 +37,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		$propertyName = $hookReflection->getHookedPropertyName();
 		$classReflection = $node->getClassReflection();
-		if (!$classReflection->hasNativeProperty($propertyName)) {
-			throw new ShouldNotHappenException();
-		}
-
-		$propertyReflection = $classReflection->getNativeProperty($propertyName);
+		$propertyReflection = $node->getPropertyReflection();
 		if ($propertyReflection->isVirtual()->yes()) {
 			return [];
 		}