infer constant types first

Author: staabm

src/Type/Php/SprintfFunctionDynamicReturnTypeExtension.php

@@ -48,11 +48,12 @@ public function getTypeFromFunctionCall(
 			return null;
 		}
 
-		$formatType = $scope->getType($args[0]->value);
-		if (count($args) === 1) {
-			return $this->getConstantType($args, null, $functionReflection, $scope);
+		$constantType = $this->getConstantType($args, $functionReflection, $scope);
+		if ($constantType !== null) {
+			return $constantType;
 		}
 
+		$formatType = $scope->getType($args[0]->value);
 		$formatStrings = $formatType->getConstantStrings();
 		if (count($formatStrings) === 0) {
 			return null;
@@ -118,19 +119,19 @@ public function getTypeFromFunctionCall(
 			$returnType = new StringType();
 		}
 
-		return $this->getConstantType($args, $returnType, $functionReflection, $scope);
+		return $returnType;
 	}
 
 	/**
 	 * @param Arg[] $args
 	 */
-	private function getConstantType(array $args, ?Type $fallbackReturnType, FunctionReflection $functionReflection, Scope $scope): ?Type
+	private function getConstantType(array $args, FunctionReflection $functionReflection, Scope $scope): ?Type
 	{
 		$values = [];
 		$combinationsCount = 1;
 		foreach ($args as $arg) {
 			if ($arg->unpack) {
-				return $fallbackReturnType;
+				return null;
 			}
 
 			$argType = $scope->getType($arg->value);
@@ -145,23 +146,23 @@ private function getConstantType(array $args, ?Type $fallbackReturnType, Functio
 			}
 
 			if (count($constantScalarValues) === 0) {
-				return $fallbackReturnType;
+				return null;
 			}
 
 			$values[] = $constantScalarValues;
 			$combinationsCount *= count($constantScalarValues);
 		}
 
 		if ($combinationsCount > InitializerExprTypeResolver::CALCULATE_SCALARS_LIMIT) {
-			return $fallbackReturnType;
+			return null;
 		}
 
 		$combinations = CombinationsHelper::combinations($values);
 		$returnTypes = [];
 		foreach ($combinations as $combination) {
 			$format = array_shift($combination);
 			if (!is_string($format)) {
-				return $fallbackReturnType;
+				return null;
 			}
 
 			try {
@@ -171,12 +172,12 @@ private function getConstantType(array $args, ?Type $fallbackReturnType, Functio
 					$returnTypes[] = $scope->getTypeFromValue(@vsprintf($format, $combination));
 				}
 			} catch (Throwable) {
-				return $fallbackReturnType;
+				return null;
 			}
 		}
 
 		if (count($returnTypes) > InitializerExprTypeResolver::CALCULATE_SCALARS_LIMIT) {
-			return $fallbackReturnType;
+			return null;
 		}
 
 		return TypeCombinator::union(...$returnTypes);