Hooked property cannot be static

Co-authored-by: Ondřej Mirtes <[email protected]>

Author: jakubtobiasz

Makefile

@@ -90,6 +90,8 @@ lint:
 		--exclude tests/PHPStan/Rules/Properties/data/hooked-properties-without-bodies-in-class.php \
 		--exclude tests/PHPStan/Rules/Properties/data/readonly-property-hooks.php \
 		--exclude tests/PHPStan/Rules/Properties/data/readonly-property-hooks-in-interface.php \
+		--exclude tests/PHPStan/Rules/Properties/data/static-hooked-properties.php \
+		--exclude tests/PHPStan/Rules/Properties/data/static-hooked-property-in-interface.php \
 		--exclude tests/PHPStan/Rules/Properties/data/virtual-hooked-properties.php \
 		--exclude tests/PHPStan/Rules/Classes/data/bug-12281.php \
 		--exclude tests/PHPStan/Rules/Traits/data/bug-12281.php \

src/Rules/Properties/PropertiesInInterfaceRule.php

@@ -66,6 +66,15 @@ public function processNode(Node $node, Scope $scope): array
 			];
 		}
 
+		if ($node->isStatic()) {
+			return [
+				RuleErrorBuilder::message('Hooked properties cannot be static.')
+					->nonIgnorable()
+					->identifier('property.hookedStatic')
+					->build(),
+			];
+		}
+
 		if ($this->hasAnyHookBody($node)) {
 			return [
 				RuleErrorBuilder::message('Interfaces cannot include property hooks with bodies.')

src/Rules/Properties/PropertyInClassRule.php

@@ -92,6 +92,17 @@ public function processNode(Node $node, Scope $scope): array
 			}
 		}
 
+		if ($node->isStatic()) {
+			if ($node->hasHooks()) {
+				return [
+					RuleErrorBuilder::message('Hooked properties cannot be static.')
+						->nonIgnorable()
+						->identifier('property.hookedStatic')
+						->build(),
+				];
+			}
+		}
+
 		if ($node->isVirtual()) {
 			if ($node->getDefault() !== null) {
 				return [

tests/PHPStan/Rules/Properties/PropertiesInInterfaceRuleTest.php

@@ -140,4 +140,26 @@ public function testPhp84AndReadonlyPropertyHooksInInterface(): void
 		]);
 	}
 
+	public function testPhp84AndStaticHookedPropertyInInterface(): void
+	{
+		if (PHP_VERSION_ID < 80400) {
+			$this->markTestSkipped('Test requires PHP 8.4 or later.');
+		}
+
+		$this->analyse([__DIR__ . '/data/static-hooked-property-in-interface.php'], [
+			[
+				'Hooked properties cannot be static.',
+				7,
+			],
+			[
+				'Hooked properties cannot be static.',
+				9,
+			],
+			[
+				'Hooked properties cannot be static.',
+				11,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Properties/PropertyInClassRuleTest.php

@@ -195,4 +195,22 @@ public function testPhp84AndVirtualHookedProperties(): void
 		]);
 	}
 
+	public function testPhp84AndStaticHookedProperties(): void
+	{
+		if (PHP_VERSION_ID < 80400) {
+			$this->markTestSkipped('Test requires PHP 8.4 or later.');
+		}
+
+		$this->analyse([__DIR__ . '/data/static-hooked-properties.php'], [
+			[
+				'Hooked properties cannot be static.',
+				7,
+			],
+			[
+				'Hooked properties cannot be static.',
+				15,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Properties/data/static-hooked-properties.php

@@ -0,0 +1,18 @@
+<?php declare(strict_types=1);
+
+namespace StaticHookedProperties;
+
+class HelloWorld
+{
+	public static string $foo {
+		get => $this->foo;
+		set => $this->foo = $value;
+	}
+}
+
+abstract class HiWorld
+{
+	public static string $foo {
+		get => 'dummy';
+	}
+}

tests/PHPStan/Rules/Properties/data/static-hooked-property-in-interface.php

@@ -0,0 +1,12 @@
+<?php declare(strict_types=1);
+
+namespace StaticHookedPropertyInInterface;
+
+interface HelloWorld
+{
+	public static string $firstName { get; set; }
+
+	public static string $middleName { get; }
+
+	public static string $lastName { set; }
+}