Do not report constructor unused parameter if implemented interface has a constructor

Author: carlos-granados

src/Rules/Classes/UnusedConstructorParametersRule.php

@@ -16,7 +16,6 @@
 use function array_values;
 use function count;
 use function sprintf;
-use function strtolower;
 
 /**
  * @implements Rule<InClassMethodNode>
@@ -37,7 +36,7 @@ public function processNode(Node $node, Scope $scope): array
 	{
 		$method = $node->getMethodReflection();
 		$originalNode = $node->getOriginalNode();
-		if (strtolower($method->getName()) !== '__construct' || $originalNode->stmts === null) {
+		if (!$method->isConstructor() || $originalNode->stmts === null) {
 			return [];
 		}
 
@@ -48,6 +47,12 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
+		foreach ($node->getClassReflection()->getInterfaces() as $interface) {
+			if ($interface->hasConstructor()) {
+				return [];
+			}
+		}
+
 		$message = sprintf(
 			'Constructor of class %s has an unused parameter $%%s.',
 			SprintfHelper::escapeFormatString($node->getClassReflection()->getDisplayName()),

tests/PHPStan/Rules/Classes/UnusedConstructorParametersRuleTest.php

@@ -71,4 +71,9 @@ public function testBug10865(): void
 		$this->analyse([__DIR__ . '/data/bug-10865.php'], []);
 	}
 
+	public function testBug11454(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-11454.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Classes/data/bug-11454.php

@@ -0,0 +1,14 @@
+<?php declare(strict_types = 1);
+
+namespace Bug11454;
+
+interface ConstructorInterface
+{
+	public function __construct(string $a);
+}
+
+class Foo implements ConstructorInterface {
+	public function __construct(string $a)
+	{
+	}
+}