PHPDoc tag @phpstan-consistent-constructor no longer requires constructor to exist

Author: ondrejmirtes

src/Rules/Classes/NewStaticRule.php

@@ -56,6 +56,10 @@ public function processNode(Node $node, Scope $scope): array
 				->build(),
 		];
 		if (!$classReflection->hasConstructor()) {
+			if ($classReflection->hasConsistentConstructor()) {
+				return [];
+			}
+
 			return $messages;
 		}
 

tests/PHPStan/Rules/Classes/NewStaticRuleTest.php

@@ -62,4 +62,9 @@ public function testBug9654(): void
 		$this->analyse([__DIR__ . '/data/bug-9654.php'], $errors);
 	}
 
+	public function testBug11316(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-11316.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Classes/data/bug-11316.php

@@ -0,0 +1,28 @@
+<?php
+
+namespace Bug11316;
+
+/** @phpstan-consistent-constructor */
+class Model
+{
+	public static function create(): static
+	{
+		return new static();
+	}
+}
+
+class ParentWithoutConstructor
+{
+
+}
+
+/** @phpstan-consistent-constructor */
+class ChildExtendingParentWithoutConstructor extends ParentWithoutConstructor
+{
+
+	public static function create(): static
+	{
+		return new static();
+	}
+
+}