fix: checking optional properties in object shapes

Author: calebdw

src/Type/ObjectShapeType.php

@@ -176,15 +176,7 @@ public function accepts(Type $type, bool $strictTypes): AcceptsResult
 			try {
 				$otherProperty = $type->getProperty($propertyName, $scope);
 			} catch (MissingPropertyFromReflectionException) {
-				return AcceptsResult::createNo(
-					[
-						sprintf(
-							'%s does not have property $%s.',
-							$type->describe(VerbosityLevel::typeOnly()),
-							$propertyName,
-						),
-					],
-				);
+				continue;
 			}
 
 			if (!$otherProperty->isPublic()) {
@@ -281,15 +273,7 @@ public function isSuperTypeOf(Type $type): IsSuperTypeOfResult
 			try {
 				$otherProperty = $type->getProperty($propertyName, $scope);
 			} catch (MissingPropertyFromReflectionException) {
-				return IsSuperTypeOfResult::createNo(
-					[
-						sprintf(
-							'%s does not have property $%s.',
-							$type->describe(VerbosityLevel::typeOnly()),
-							$propertyName,
-						),
-					],
-				);
+				continue;
 			}
 			if (!$otherProperty->isPublic()) {
 				return IsSuperTypeOfResult::createNo();

tests/PHPStan/Analyser/AnalyserIntegrationTest.php

@@ -1541,6 +1541,12 @@ public function testBug13310(): void
 		$this->assertNoErrors($errors);
 	}
 
+	public function testBug13511(): void
+	{
+		$errors = $this->runAnalyse(__DIR__ . '/data/bug-13511.php');
+		$this->assertNoErrors($errors);
+	}
+
 	/**
 	 * @param string[]|null $allAnalysedFiles
 	 * @return Error[]

tests/PHPStan/Analyser/data/bug-13511.php

@@ -0,0 +1,24 @@
+<?php
+
+namespace Bug13511;
+
+class User
+{
+	public function __construct(
+		public string $name,
+		public string $email,
+	) {}
+}
+
+class Printer
+{
+	/** @param object{name: string, email: string, phone?: string} $object */
+	function printInfo(object $object): void
+	{
+		return;
+	}
+}
+
+function (Printer $printer, User $user): void {
+	$printer->printInfo($user);
+};