Hooked properties cannot be unset()

Author: staabm

src/Rules/Variables/UnsetRule.php

@@ -103,6 +103,19 @@ private function canBeUnset(Node $node, Scope $scope): ?IdentifierRuleError
 					->identifier($propertyReflection->isReadOnly() ? 'unset.readOnlyProperty' : 'unset.readOnlyPropertyByPhpDoc')
 					->build();
 			}
+
+			if ($propertyReflection->getNativeReflection()->getHooks() !== []) {
+				return RuleErrorBuilder::message(
+					sprintf(
+						'Cannot unset hooked property %s::$%s.',
+						$propertyReflection->getDeclaringClass()->getDisplayName(),
+						$foundPropertyReflection->getName(),
+					),
+				)
+					->line($node->getStartLine())
+					->identifier('unset.hookedProperty')
+					->build();
+			}
 		}
 
 		return null;

tests/PHPStan/Rules/Variables/UnsetRuleTest.php

@@ -5,6 +5,7 @@
 use PHPStan\Rules\Properties\PropertyReflectionFinder;
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
+use const PHP_VERSION_ID;
 
 /**
  * @extends RuleTestCase<UnsetRule>
@@ -122,4 +123,30 @@ public function testBug12421(): void
 		]);
 	}
 
+	public function testUnsetHookedProperty(): void
+	{
+		if (PHP_VERSION_ID < 80400) {
+			$this->markTestSkipped('Test requires PHP 8.4 or later.');
+		}
+
+		$this->analyse([__DIR__ . '/data/unset-hooked-property.php'], [
+			[
+				'Cannot unset hooked property UnsetHookedProperty\User::$name.',
+				6,
+			],
+			[
+				'Cannot unset hooked property UnsetHookedProperty\User::$fullName.',
+				7,
+			],
+			[
+				'Cannot unset hooked property UnsetHookedProperty\Foo::$ii.',
+				9,
+			],
+			[
+				'Cannot unset hooked property UnsetHookedProperty\Foo::$iii.',
+				10,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Variables/data/unset-hooked-property.php

@@ -0,0 +1,41 @@
+<?php // lint >= 8.4
+
+namespace UnsetHookedProperty;
+
+function doUnset(Foo $foo, User $user): void {
+	unset($user->name);
+	unset($user->fullName);
+
+	unset($foo->ii);
+	unset($foo->iii);
+}
+
+class User
+{
+	public string $name {
+		set {
+			if (strlen($value) === 0) {
+				throw new \ValueError("Name must be non-empty");
+			}
+			$this->name = $value;
+		}
+	}
+
+	public string $fullName {
+		get {
+			return "Yennefer of Vengerberg";
+		}
+	}
+
+	public function __construct(string $name) {
+		$this->name = $name;
+	}
+}
+
+abstract class Foo
+{
+	abstract protected int $ii { get; }
+
+	abstract public int $iii { get; }
+}
+