Prevent setting a default value for a virtual property

Author: jakubtobiasz

Makefile

@@ -90,6 +90,7 @@ lint:
 		--exclude tests/PHPStan/Rules/Properties/data/hooked-properties-without-bodies-in-class.php \
 		--exclude tests/PHPStan/Rules/Properties/data/readonly-property-hooks.php \
 		--exclude tests/PHPStan/Rules/Properties/data/readonly-property-hooks-in-interface.php \
+		--exclude tests/PHPStan/Rules/Properties/data/virtual-hooked-properties.php \
 		--exclude tests/PHPStan/Rules/Classes/data/bug-12281.php \
 		--exclude tests/PHPStan/Rules/Traits/data/bug-12281.php \
 		--exclude tests/PHPStan/Rules/Classes/data/invalid-hooked-properties.php \

src/Node/ClassPropertyNode.php

@@ -160,4 +160,9 @@ public function getHooks(): array
 		return $this->originalNode->hooks;
 	}
 
+	public function isVirtual(): bool
+	{
+		return $this->classReflection->getNativeProperty($this->name)->isVirtual()->yes();
+	}
+
 }

src/Rules/Properties/PropertyInClassRule.php

@@ -92,6 +92,17 @@ public function processNode(Node $node, Scope $scope): array
 			}
 		}
 
+		if ($node->isVirtual()) {
+			if ($node->getDefault() !== null) {
+				return [
+					RuleErrorBuilder::message('Virtual hooked properties cannot have a default value.')
+						->nonIgnorable()
+						->identifier('property.virtualDefault')
+						->build(),
+				];
+			}
+		}
+
 		return [];
 	}
 

tests/PHPStan/Rules/Properties/PropertyInClassRuleTest.php

@@ -181,4 +181,18 @@ public function testPhp84AndReadonlyHookedProperties(): void
 		]);
 	}
 
+	public function testPhp84AndVirtualHookedProperties(): void
+	{
+		if (PHP_VERSION_ID < 80400) {
+			$this->markTestSkipped('Test requires PHP 8.4 or later.');
+		}
+
+		$this->analyse([__DIR__ . '/data/virtual-hooked-properties.php'], [
+			[
+				'Virtual hooked properties cannot have a default value.',
+				17,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Properties/data/virtual-hooked-properties.php

@@ -0,0 +1,22 @@
+<?php declare(strict_types=1);
+
+namespace VirtualHookedProperties;
+
+class HelloWorld
+{
+	public string $firstName = 'John' {
+		get => $this->firstName;
+		set => $this->firstName = $value;
+	}
+
+	public string $middleName {
+		get => $this->middleName;
+		set => $this->middleName = $value;
+	}
+
+	public string $lastName = 'Doe' {
+		get => 'Smith';
+	}
+
+	public string $maidenName = 'Brown';
+}