Implement SocketCreateReturnTypeExtension

Author: staabm

conf/config.neon

@@ -1820,6 +1820,11 @@ services:
 		tags:
 			- phpstan.broker.dynamicMethodReturnTypeExtension
 
+	-
+		class: PHPStan\Type\Php\SocketCreateReturnTypeExtension
+		tags:
+			- phpstan.broker.dynamicFunctionReturnTypeExtension
+
 	-
 		class: PHPStan\Type\Php\StrSplitFunctionReturnTypeExtension
 		tags:

src/Php/PhpVersions.php

@@ -23,4 +23,9 @@ public function producesWarningForFinalPrivateMethods(): TrinaryLogic
 		return IntegerRangeType::fromInterval(80000, null)->isSuperTypeOf($this->phpVersions)->result;
 	}
 
+	public function socketCreateUsesResource(): TrinaryLogic
+	{
+		return IntegerRangeType::fromInterval(null, 80000)->isSuperTypeOf($this->phpVersions)->result;
+	}
+
 }

src/Type/Php/SocketCreateReturnTypeExtension.php

@@ -0,0 +1,42 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Type\Php;
+
+use PhpParser\Node\Expr\FuncCall;
+use PHPStan\Analyser\Scope;
+use PHPStan\Reflection\FunctionReflection;
+use PHPStan\Type\Constant\ConstantBooleanType;
+use PHPStan\Type\DynamicFunctionReturnTypeExtension;
+use PHPStan\Type\ObjectType;
+use PHPStan\Type\ResourceType;
+use PHPStan\Type\Type;
+use PHPStan\Type\UnionType;
+use Socket;
+use function count;
+
+final class SocketCreateReturnTypeExtension implements DynamicFunctionReturnTypeExtension
+{
+
+	public function isFunctionSupported(FunctionReflection $functionReflection): bool
+	{
+		return $functionReflection->getName() === 'socket_create';
+	}
+
+	public function getTypeFromFunctionCall(FunctionReflection $functionReflection, FuncCall $functionCall, Scope $scope): ?Type
+	{
+		if (count($functionCall->getArgs()) < 3) {
+			return null;
+		}
+
+		if ($scope->getPhpVersion()->socketCreateUsesResource()->no()) {
+			return new UnionType([new ConstantBooleanType(false), new ObjectType(Socket::class)]);
+		}
+
+		if ($scope->getPhpVersion()->socketCreateUsesResource()->yes()) {
+			return new UnionType([new ConstantBooleanType(false), new ResourceType()]);
+		}
+
+		return null;
+	}
+
+}

tests/PHPStan/Analyser/nsrt/socket-create.php

@@ -0,0 +1,19 @@
+<?php // lint >= 7.4
+
+declare(strict_types=1);
+
+namespace SocketCreate;
+
+use function PHPStan\Testing\assertType;
+
+class HelloWorld
+{
+	public function sayHello(): void
+	{
+		if (PHP_VERSION_ID < 80000) {
+			assertType('resource|false', socket_create(AF_INET, SOCK_DGRAM, SOL_UDP));
+			return;
+		}
+		assertType('Socket|false', socket_create(AF_INET, SOCK_DGRAM, SOL_UDP));
+	}
+}