!array_key_exists() should imply array for PHP8+

Author: staabm

src/Type/Php/ArrayKeyExistsFunctionTypeSpecifyingExtension.php

@@ -13,6 +13,7 @@
 use PHPStan\Analyser\TypeSpecifierAwareExtension;
 use PHPStan\Analyser\TypeSpecifierContext;
 use PHPStan\DependencyInjection\AutowiredService;
+use PHPStan\Php\PhpVersion;
 use PHPStan\Reflection\FunctionReflection;
 use PHPStan\Type\Accessory\HasOffsetType;
 use PHPStan\Type\Accessory\NonEmptyArrayType;
@@ -31,6 +32,12 @@ final class ArrayKeyExistsFunctionTypeSpecifyingExtension implements FunctionTyp
 
 	private TypeSpecifier $typeSpecifier;
 
+	public function __construct(
+		private PhpVersion $phpVersion,
+	)
+	{
+	}
+
 	public function setTypeSpecifier(TypeSpecifier $typeSpecifier): void
 	{
 		$this->typeSpecifier = $typeSpecifier;
@@ -110,6 +117,14 @@ public function specifyTypes(
 				new ArrayType(new MixedType(), new MixedType()),
 				new HasOffsetType($keyType),
 			);
+		} elseif (
+			$this->phpVersion->throwsValueErrorForInternalFunctions()
+			&& $arrayType instanceof MixedType
+		) {
+			$type = TypeCombinator::intersect(
+				new ArrayType(new MixedType(), new MixedType()),
+			);
+			$context = $context->negate();
 		} else {
 			$type = new HasOffsetType($keyType);
 		}

tests/PHPStan/Analyser/nsrt/bug-13270b-php8.php

@@ -0,0 +1,30 @@
+<?php // lint >= 8.0
+
+declare(strict_types=1);
+
+namespace Bug13270b;
+
+use function PHPStan\Testing\assertType;
+
+class Test
+{
+	/**
+	 * @param mixed[] $data
+	 * @return mixed[]
+	 */
+	public function parseData(array $data): array
+	{
+		if (isset($data['price'])) {
+			assertType('mixed~null', $data['price']);
+			if (!array_key_exists('priceWithVat', $data['price'])) {
+				$data['price']['priceWithVat'] = null;
+			}
+			assertType("non-empty-array&hasOffsetValue('priceWithVat', mixed)", $data['price']);
+			if (!array_key_exists('priceWithoutVat', $data['price'])) {
+				$data['price']['priceWithoutVat'] = null;
+			}
+			assertType("non-empty-array&hasOffsetValue('priceWithoutVat', mixed)&hasOffsetValue('priceWithVat', mixed)", $data['price']);
+		}
+		return $data;
+	}
+}

tests/PHPStan/Analyser/nsrt/bug-13270b.php

@@ -1,4 +1,6 @@
-<?php declare(strict_types=1);
+<?php // lint < 8.0
+
+declare(strict_types=1);
 
 namespace Bug13270b;
 

tests/PHPStan/Analyser/nsrt/bug-13301-php8.php

@@ -0,0 +1,15 @@
+<?php // lint >= 8.0
+
+namespace Bug13301Php8;
+
+use function PHPStan\Testing\assertType;
+
+function doFoo($mixed) {
+	if (array_key_exists('a', $mixed)) {
+		assertType("non-empty-array&hasOffset('a')", $mixed);
+		echo "has-a";
+	} else {
+		assertType('array', $mixed); // could be array~hasOffset('a') after arrays got subtractable
+		echo "NO-a";
+	}
+}

tests/PHPStan/Analyser/nsrt/bug-13301.php

@@ -0,0 +1,15 @@
+<?php // lint < 8.0
+
+namespace Bug13301Php7;
+
+use function PHPStan\Testing\assertType;
+
+function doFoo($mixed) {
+	if (array_key_exists('a', $mixed)) {
+		assertType("non-empty-array&hasOffset('a')", $mixed);
+		echo "has-a";
+	} else {
+		assertType("mixed~hasOffset('a')", $mixed);
+		echo "NO-a";
+	}
+}