Fix

Author: VincentLanglet

src/Reflection/ParametersAcceptorSelector.php

@@ -205,7 +205,7 @@ public static function selectFromArgs(
 			}
 
 			if (isset($args[0]) && (bool) $args[0]->getAttribute(ImplodeArgVisitor::ATTRIBUTE_NAME)) {
-				if (isset($args[1])) {
+				if (isset($args[1]) || $args[0]->name?->name === 'array') {
 					$parameters = [
 						new NativeParameterReflection('separator', false, new StringType(), PassedByReference::createNo(), false, null),
 						new NativeParameterReflection('array', false, new ArrayType(new MixedType(), new MixedType()), PassedByReference::createNo(), false, null),

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

@@ -364,6 +364,20 @@ public function testImplodeOnLessThanPhp74(): void
 		$this->analyse([__DIR__ . '/data/implode-74.php'], $errors);
 	}
 
+	public function testImplodeNamedParameters(): void
+	{
+		$this->analyse([__DIR__ . '/data/implode-named-parameters.php'], [
+			[
+				'Missing parameter $separator (string) in call to function implode.',
+				6,
+			],
+			[
+				'Missing parameter $separator (string) in call to function join.',
+				7,
+			],
+		]);
+	}
+
 	public function testVariableIsNotNullAfterSeriesOfConditions(): void
 	{
 		require_once __DIR__ . '/data/variable-is-not-null-after-conditions.php';

tests/PHPStan/Rules/Functions/data/implode-named-parameters.php

@@ -0,0 +1,10 @@
+<?php declare(strict_types = 1);
+
+namespace ImplodeNamedParameters;
+
+function (): void {
+	implode(array: ['']); // error
+	join(array: ['']); // error
+	implode(separator: '', array: ['']);
+	join(separator: '', array: ['']);
+};