Trinary logic

Author: DanielEScherzer

src/Reflection/FunctionReflection.php

@@ -62,4 +62,11 @@ public function isPure(): TrinaryLogic;
 	 */
 	public function getAttributes(): array;
 
+	/**
+	 * Has the #[\NoDiscard] attribute - on PHP 8.5+ if the function's return
+	 * value is unused at runtime a warning is emitted, phpstan will emit the
+	 * warning during analysis and on older PHP versions too
+	 */
+	public function hasNoDiscardAttribute(): TrinaryLogic;
+
 }

src/Reflection/Php/PhpFunctionFromParserNodeReflection.php

@@ -330,4 +330,14 @@ public function getAttributes(): array
 		return $this->attributes;
 	}
 
+	public function hasNoDiscardAttribute(): TrinaryLogic
+	{
+		foreach ($this->attributes as $attrib) {
+			if ($attrib->getName() === 'NoDiscard') {
+				return TrinaryLogic::createYes();
+			}
+		}
+		return TrinaryLogic::createNo();
+	}
+
 }

src/Reflection/Php/PhpFunctionReflection.php

@@ -275,4 +275,14 @@ public function getAttributes(): array
 		return $this->attributes;
 	}
 
+	public function hasNoDiscardAttribute(): TrinaryLogic
+	{
+		foreach ($this->attributes as $attrib) {
+			if ($attrib->getName() === 'NoDiscard') {
+				return TrinaryLogic::createYes();
+			}
+		}
+		return TrinaryLogic::createNo();
+	}
+
 }

src/Rules/Functions/CallToFunctionStatementWithNoDiscardRule.php

@@ -43,15 +43,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		$function = $this->reflectionProvider->getFunction($funcCall->name, $scope);
 
-		$attributes = $function->getAttributes();
-		$hasNoDiscard = false;
-		foreach ($attributes as $attrib) {
-			if ($attrib->getName() === 'NoDiscard') {
-				$hasNoDiscard = true;
-				break;
-			}
-		}
-		if (!$hasNoDiscard) {
+		if (!$function->hasNoDiscardAttribute()->yes()) {
 			return [];
 		}