Fix subtracting enums inside in_array when const set is used

Author: janedbal

src/Type/Php/InArrayFunctionTypeSpecifyingExtension.php

@@ -110,7 +110,7 @@ public function specifyTypes(FunctionReflection $functionReflection, FuncCall $n
 			$context->true()
 			|| (
 				$context->false()
-				&& count($arrayValueType->getFiniteTypes()) === 1
+				&& count($arrayValueType->getFiniteTypes()) > 0
 			)
 		) {
 			$specifiedTypes = $this->typeSpecifier->create(

tests/PHPStan/Analyser/AnalyserIntegrationTest.php

@@ -1480,6 +1480,12 @@ public function testBug11913(): void
 		$this->assertNoErrors($errors);
 	}
 
+	public function testBug12083InArrayEnum(): void
+	{
+		$errors = $this->runAnalyse(__DIR__ . '/data/enum-in-array.php');
+		$this->assertNoErrors($errors);
+	}
+
 	/**
 	 * @param string[]|null $allAnalysedFiles
 	 * @return Error[]

tests/PHPStan/Analyser/data/enum-in-array.php

@@ -0,0 +1,22 @@
+<?php
+
+enum MyEnum: string
+{
+
+	case A = 'a';
+	case B = 'b';
+	case C = 'c';
+
+	const SET1 = [self::A, self::B, self::C];
+
+}
+
+
+foreach ([MyEnum::A, MyEnum::B, MyEnum::C] as $enum) {
+
+	if (in_array($enum, MyEnum::SET1, true)) {
+
+	} else {
+		\PHPStan\Testing\assertType('*NEVER*', $enum);
+	}
+}