Utilize PropertyReflectionFinder

Author: staabm

src/Rules/Variables/UnsetRule.php

@@ -5,6 +5,7 @@
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\IdentifierRuleError;
+use PHPStan\Rules\Properties\PropertyReflectionFinder;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\Type\VerbosityLevel;
@@ -17,6 +18,12 @@
 final class UnsetRule implements Rule
 {
 
+	public function __construct(
+		private PropertyReflectionFinder $propertyReflectionFinder,
+	)
+	{
+	}
+
 	public function getNodeType(): string
 	{
 		return Node\Stmt\Unset_::class;
@@ -73,26 +80,30 @@ private function canBeUnset(Node $node, Scope $scope): ?IdentifierRuleError
 			$node instanceof Node\Expr\PropertyFetch
 			&& $node->name instanceof Node\Identifier
 		) {
-			$type = $scope->getType($node->var);
-			foreach ($type->getObjectClassReflections() as $classReflection) {
-				if (!$classReflection->hasNativeProperty($node->name->name)) {
-					continue;
-				}
-
-				$propertyReflection = $classReflection->getNativeProperty($node->name->name);
-				if ($propertyReflection->isReadOnly() || $propertyReflection->isReadOnlyByPhpDoc()) {
-					return RuleErrorBuilder::message(
-						sprintf(
-							'Cannot unset %s property %s of %s.',
-							$propertyReflection->isReadOnly() ? 'readonly' : '@readonly',
-							$node->name->name,
-							$type->describe(VerbosityLevel::value()),
-						),
-					)
-						->line($node->getStartLine())
-						->identifier($propertyReflection->isReadOnly() ? 'unset.readOnlyProperty' : 'unset.readOnlyPropertyByPhpDoc')
-						->build();
-				}
+			$foundPropertyReflection = $this->propertyReflectionFinder->findPropertyReflectionFromNode($node, $scope);
+			if ($foundPropertyReflection === null) {
+				return null;
+			}
+
+			$propertyReflection = $foundPropertyReflection->getNativeReflection();
+			if ($propertyReflection === null) {
+				return null;
+			}
+
+			if ($propertyReflection->isReadOnly() || $propertyReflection->isReadOnlyByPhpDoc()) {
+				$type = $scope->getType($node->var);
+
+				return RuleErrorBuilder::message(
+					sprintf(
+						'Cannot unset %s property %s of %s.',
+						$propertyReflection->isReadOnly() ? 'readonly' : '@readonly',
+						$node->name->name,
+						$type->describe(VerbosityLevel::value()),
+					),
+				)
+					->line($node->getStartLine())
+					->identifier($propertyReflection->isReadOnly() ? 'unset.readOnlyProperty' : 'unset.readOnlyPropertyByPhpDoc')
+					->build();
 			}
 		}
 

tests/PHPStan/Rules/Variables/UnsetRuleTest.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Rules\Variables;
 
+use PHPStan\Rules\Properties\PropertyReflectionFinder;
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
 
@@ -13,7 +14,7 @@ class UnsetRuleTest extends RuleTestCase
 
 	protected function getRule(): Rule
 	{
-		return new UnsetRule();
+		return new UnsetRule(self::getContainer()->getByType(PropertyReflectionFinder::class));
 	}
 
 	public function testUnsetRule(): void