Fix internal error with checkDynamicProperties: true

Author: ondrejmirtes

src/Type/IntersectionType.php

@@ -561,7 +561,7 @@ public function getUnresolvedInstancePropertyPrototype(string $propertyName, Cla
 
 		$propertiesCount = count($propertyPrototypes);
 		if ($propertiesCount === 0) {
-			throw new ShouldNotHappenException();
+			throw new MissingPropertyFromReflectionException($this->describe(VerbosityLevel::typeOnly()), $propertyName);
 		}
 
 		if ($propertiesCount === 1) {
@@ -594,7 +594,7 @@ public function getUnresolvedStaticPropertyPrototype(string $propertyName, Class
 
 		$propertiesCount = count($propertyPrototypes);
 		if ($propertiesCount === 0) {
-			throw new ShouldNotHappenException();
+			throw new MissingPropertyFromReflectionException($this->describe(VerbosityLevel::typeOnly()), $propertyName);
 		}
 
 		if ($propertiesCount === 1) {

src/Type/UnionType.php

@@ -516,7 +516,7 @@ public function getUnresolvedInstancePropertyPrototype(string $propertyName, Cla
 
 		$propertiesCount = count($propertyPrototypes);
 		if ($propertiesCount === 0) {
-			throw new ShouldNotHappenException();
+			throw new MissingPropertyFromReflectionException($this->describe(VerbosityLevel::typeOnly()), $propertyName);
 		}
 
 		if ($propertiesCount === 1) {
@@ -549,7 +549,7 @@ public function getUnresolvedStaticPropertyPrototype(string $propertyName, Class
 
 		$propertiesCount = count($propertyPrototypes);
 		if ($propertiesCount === 0) {
-			throw new ShouldNotHappenException();
+			throw new MissingPropertyFromReflectionException($this->describe(VerbosityLevel::typeOnly()), $propertyName);
 		}
 
 		if ($propertiesCount === 1) {

tests/PHPStan/Analyser/AnalyserWithCheckDynamicPropertiesTest.php

@@ -0,0 +1,53 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Analyser;
+
+use PHPStan\Testing\PHPStanTestCase;
+
+class AnalyserWithCheckDynamicPropertiesTest extends PHPStanTestCase
+{
+
+	public function testBug13529(): void
+	{
+		$errors = $this->runAnalyse(__DIR__ . '/data/bug-13529.php');
+		$this->assertCount(1, $errors);
+		$this->assertSame('Access to an undefined property object::$bar.', $errors[0]->getMessage());
+		$this->assertSame(8, $errors[0]->getLine());
+	}
+
+	/**
+	 * @param string[]|null $allAnalysedFiles
+	 * @return Error[]
+	 */
+	private function runAnalyse(string $file): array
+	{
+		$file = $this->getFileHelper()->normalizePath($file);
+
+		$analyser = self::getContainer()->getByType(Analyser::class);
+		$finalizer = self::getContainer()->getByType(AnalyserResultFinalizer::class);
+		$errors = $finalizer->finalize(
+			$analyser->analyse([$file], null, null, true),
+			false,
+			true,
+		)->getErrors();
+		foreach ($errors as $error) {
+			$this->assertSame($file, $error->getFilePath());
+		}
+
+		return $errors;
+	}
+
+	public static function getAdditionalConfigFiles(): array
+	{
+		return array_unique(
+			array_merge(
+				parent::getAdditionalConfigFiles(),
+				[
+					__DIR__ . '/checkDynamicProperties.neon',
+				],
+			),
+		);
+	}
+
+
+}

tests/PHPStan/Analyser/checkDynamicProperties.neon

@@ -0,0 +1,2 @@
+parameters:
+	checkDynamicProperties: true

tests/PHPStan/Analyser/data/bug-13529.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace Bug13529;
+
+function broken(string $x): void {
+	$tmp = json_decode($x, false);
+
+	if (!isset($tmp->foo) || !isset($tmp->bar)) {
+	}
+}