Skip to content

Commit c764f78

Browse files
committed
[BE] Change curl_setopt function signature based on 2nd arg
1 parent 8bf527b commit c764f78

File tree

4 files changed

+3
-6
lines changed

4 files changed

+3
-6
lines changed

changelog-2.0.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ Bleeding edge (TODO move to other sections)
5454
* Move IllegalConstructorMethodCallRule and IllegalConstructorStaticCallRule to phpstan-strict-rules (https://github.com/phpstan/phpstan-src/commit/124b30f98c182193187be0b9c2e151e477429b7a, https://github.com/phpstan/phpstan-strict-rules/commit/0c82c96f2a55d8b91bbc7ee6512c94f68a206b43)
5555
* Add `@readonly` rule that disallows default values ([#1391](https://github.com/phpstan/phpstan-src/pull/1391)), thanks @herndlm!
5656
* MissingMagicSerializationMethodsRule ([#1711](https://github.com/phpstan/phpstan-src/pull/1711)), #7482, thanks @staabm!
57-
* Change `curl_setopt` function signature based on 2nd arg ([#1719](https://github.com/phpstan/phpstan-src/pull/1719)), thanks @staabm!
5857
* Empty `skipCheckGenericClasses` (https://github.com/phpstan/phpstan-src/commit/28c2c79b16cac6ba6b01f1b4d211541dd49d8a77)
5958
* Validate inline PHPDoc `@var` tag type against native type (https://github.com/phpstan/phpstan-src/commit/a69e3bc2f1e87f6da1e65d7935f1cc36bd5c42fe)
6059
* Set [`reportWrongPhpDocTypeInVarTag`](https://phpstan.org/config-reference#reportwrongphpdoctypeinvartag) to `true` to have all types validated, not just native ones
@@ -154,6 +153,7 @@ Function signature fixes 🤖
154153
* More precise `RecursiveIteratorIterator::__construct()` parameter types ([#2835](https://github.com/phpstan/phpstan-src/pull/2835)), thanks @staabm!
155154
* Update `Locale` signatures ([#2880](https://github.com/phpstan/phpstan-src/pull/2880)), thanks @devnix!
156155
* Improved the type of the `$mode` parameter for the `count()` ([#3190](https://github.com/phpstan/phpstan-src/pull/3190)), thanks @kuma3!* Check `filter_input*` type param type ([#2271](https://github.com/phpstan/phpstan-src/pull/2271)), thanks @herndlm!
156+
* Change `curl_setopt` function signature based on 2nd arg ([#1719](https://github.com/phpstan/phpstan-src/pull/1719)), thanks @staabm!
157157

158158
Internals 🔍
159159
=====================

conf/bleedingEdge.neon

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ parameters:
1313
consistentConstructor: true
1414
checkUnresolvableParameterTypes: true
1515
readOnlyByPhpDoc: true
16-
curlSetOptTypes: true
1716
missingMagicSerializationRule: true
1817
alwaysCheckTooWideReturnTypeFinalMethods: true
1918
alwaysTrueAlwaysReported: true

conf/config.neon

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ parameters:
3434
consistentConstructor: false
3535
checkUnresolvableParameterTypes: false
3636
readOnlyByPhpDoc: false
37-
curlSetOptTypes: false
3837
missingMagicSerializationRule: false
3938
alwaysCheckTooWideReturnTypeFinalMethods: false
4039
alwaysTrueAlwaysReported: false
@@ -244,8 +243,6 @@ conditionalTags:
244243
phpstan.rules.rule: %exceptions.check.tooWideThrowType%
245244
PHPStan\Rules\Exceptions\TooWideMethodThrowTypeRule:
246245
phpstan.rules.rule: %exceptions.check.tooWideThrowType%
247-
PHPStan\Parser\CurlSetOptArgVisitor:
248-
phpstan.parser.richParserNodeVisitor: %featureToggles.curlSetOptTypes%
249246

250247
services:
251248
-
@@ -297,6 +294,8 @@ services:
297294

298295
-
299296
class: PHPStan\Parser\CurlSetOptArgVisitor
297+
tags:
298+
- phpstan.parser.richParserNodeVisitor
300299

301300
-
302301
class: PHPStan\Parser\TypeTraverserInstanceofVisitor

conf/parametersSchema.neon

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ parametersSchema:
4040
consistentConstructor: bool()
4141
checkUnresolvableParameterTypes: bool()
4242
readOnlyByPhpDoc: bool()
43-
curlSetOptTypes: bool()
4443
missingMagicSerializationRule: bool()
4544
alwaysCheckTooWideReturnTypeFinalMethods: bool()
4645
alwaysTrueAlwaysReported: bool()

0 commit comments

Comments
 (0)