Fix bitwise on mixed

Author: VincentLanglet

src/Reflection/InitializerExprTypeResolver.php

@@ -647,9 +647,14 @@ public function getBitwiseAndType(Expr $left, Expr $right, callable $getTypeCall
 			$rightType = $this->optimizeScalarType($rightType);
 		}
 
-		if ($leftType->isString()->yes() && $rightType->isString()->yes()) {
+		$leftIsString = $leftType->isString();
+		$rightIsString = $rightType->isString();
+		if ($leftIsString->yes() && $rightIsString->yes()) {
 			return new StringType();
 		}
+		if ($leftIsString->maybe() && $rightIsString->maybe()) {
+			return new ErrorType();
+		}
 
 		$leftNumberType = $leftType->toNumber();
 		$rightNumberType = $rightType->toNumber();
@@ -716,9 +721,14 @@ public function getBitwiseOrType(Expr $left, Expr $right, callable $getTypeCallb
 			$rightType = $this->optimizeScalarType($rightType);
 		}
 
-		if ($leftType->isString()->yes() && $rightType->isString()->yes()) {
+		$leftIsString = $leftType->isString();
+		$rightIsString = $rightType->isString();
+		if ($leftIsString->yes() && $rightIsString->yes()) {
 			return new StringType();
 		}
+		if ($leftIsString->maybe() && $rightIsString->maybe()) {
+			return new ErrorType();
+		}
 
 		if (TypeCombinator::union($leftType->toNumber(), $rightType->toNumber()) instanceof ErrorType) {
 			return new ErrorType();
@@ -775,9 +785,14 @@ public function getBitwiseXorType(Expr $left, Expr $right, callable $getTypeCall
 			$rightType = $this->optimizeScalarType($rightType);
 		}
 
-		if ($leftType->isString()->yes() && $rightType->isString()->yes()) {
+		$leftIsString = $leftType->isString();
+		$rightIsString = $rightType->isString();
+		if ($leftIsString->yes() && $rightIsString->yes()) {
 			return new StringType();
 		}
+		if ($leftIsString->maybe() && $rightIsString->maybe()) {
+			return new ErrorType();
+		}
 
 		if (TypeCombinator::union($leftType->toNumber(), $rightType->toNumber()) instanceof ErrorType) {
 			return new ErrorType();

tests/PHPStan/Analyser/nsrt/bitwise.php

@@ -0,0 +1,45 @@
+<?php
+
+namespace Bitwise;
+
+use function PHPStan\Testing\assertType;
+
+/**
+ * @param string|int $stringOrInt
+ * @param mixed $mixed
+ */
+function test(int $int, string $string, $stringOrInt, $mixed) : void
+{
+	assertType('int', $int & $int);
+	assertType('*ERROR*', $int & $string);
+	assertType('*ERROR*', $int & $stringOrInt);
+	assertType('int', $int & $mixed);
+	assertType('string', $string & $string);
+	assertType('*ERROR*', $string & $stringOrInt);
+	assertType('*ERROR*', $string & $mixed);
+	assertType('*ERROR*', $stringOrInt & $stringOrInt);
+	assertType('*ERROR*', $stringOrInt & $mixed);
+	assertType('*ERROR*', $mixed & $mixed);
+
+	assertType('int', $int | $int);
+	assertType('*ERROR*', $int | $string);
+	assertType('*ERROR*', $int | $stringOrInt);
+	assertType('int', $int | $mixed);
+	assertType('string', $string | $string);
+	assertType('*ERROR*', $string | $stringOrInt);
+	assertType('*ERROR*', $string | $mixed);
+	assertType('*ERROR*', $stringOrInt | $stringOrInt);
+	assertType('*ERROR*', $stringOrInt | $mixed);
+	assertType('*ERROR*', $mixed | $mixed);
+
+	assertType('int', $int ^ $int);
+	assertType('*ERROR*', $int ^ $string);
+	assertType('*ERROR*', $int ^ $stringOrInt);
+	assertType('int', $int ^ $mixed);
+	assertType('string', $string ^ $string);
+	assertType('*ERROR*', $string ^ $stringOrInt);
+	assertType('*ERROR*', $string ^ $mixed);
+	assertType('*ERROR*', $stringOrInt ^ $stringOrInt);
+	assertType('*ERROR*', $stringOrInt ^ $mixed);
+	assertType('*ERROR*', $mixed ^ $mixed);
+}

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

@@ -2361,6 +2361,11 @@ public function testBug11863(): void
 		$this->analyse([__DIR__ . '/data/bug-11863.php'], []);
 	}
 
+	public function testBug8094(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-8094.php'], []);
+	}
+
 	public function testBug13556(): void
 	{
 		$this->checkExplicitMixed = true;

tests/PHPStan/Rules/Functions/data/bug-8094.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace Bug8094;
+
+function mask_encode($data, $mask)
+{
+	$mask = substr($mask, 0, strlen($data));
+	$data ^= $mask;
+	return(base64_encode($data));
+}