NoDiscard on hooks

Author: DanielEScherzer

src/Rules/AttributesCheck.php

@@ -40,6 +40,7 @@ public function check(
 		array $attrGroups,
 		int $requiredTarget,
 		string $targetName,
+		bool $isPropertyHook = false,
 	): array
 	{
 		$errors = [];
@@ -81,6 +82,12 @@ public function check(
 						->identifier('attribute.target')
 						->line($attribute->getStartLine())
 						->build();
+				} elseif ($isPropertyHook && strtolower($name) === "nodiscard") {
+					// #[\NoDiscard] cannot be used on property hooks
+					$errors[] = RuleErrorBuilder::message(sprintf('Attribute class %s cannot be used on property hooks.', $name))
+						->identifier('attribute.target')
+						->line($attribute->getStartLine())
+						->build();
 				}
 
 				if (($flags & Attribute::IS_REPEATABLE) === 0) {

src/Rules/Properties/PropertyHookAttributesRule.php

@@ -33,6 +33,7 @@ public function processNode(Node $node, Scope $scope): array
 			$node->getOriginalNode()->attrGroups,
 			Attribute::TARGET_METHOD,
 			'method',
+			true,
 		);
 	}
 

tests/PHPStan/Rules/Properties/PropertyHookAttributesRuleTest.php

@@ -55,6 +55,10 @@ public function testRule(): void
 				'Attribute class PropertyHookAttributes\Foo does not have the method target.',
 				27,
 			],
+			[
+				'Attribute class NoDiscard cannot be used on property hooks.',
+				63,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Properties/data/property-hook-attributes.php

@@ -55,3 +55,14 @@ class Dolor
 	}
 
 }
+
+class Sit
+{
+
+	public int $i {
+		#[\NoDiscard]
+		get {
+
+		}
+	}
+}