Fix unsetting array item triggers unset.possiblyHookedProperty

Author: staabm

src/Rules/Variables/UnsetRule.php

@@ -48,7 +48,7 @@ public function processNode(Node $node, Scope $scope): array
 		return $errors;
 	}
 
-	private function canBeUnset(Node $node, Scope $scope): ?IdentifierRuleError
+	private function canBeUnset(Node $node, Scope $scope, bool $inArrayDimFetch = false): ?IdentifierRuleError
 	{
 		if ($node instanceof Node\Expr\Variable && is_string($node->name)) {
 			$hasVariable = $scope->hasVariableType($node->name);
@@ -77,7 +77,7 @@ private function canBeUnset(Node $node, Scope $scope): ?IdentifierRuleError
 					->build();
 			}
 
-			return $this->canBeUnset($node->var, $scope);
+			return $this->canBeUnset($node->var, $scope, true);
 		} elseif (
 			$node instanceof Node\Expr\PropertyFetch
 			&& $node->name instanceof Node\Identifier
@@ -117,7 +117,7 @@ private function canBeUnset(Node $node, Scope $scope): ?IdentifierRuleError
 					->line($node->getStartLine())
 					->identifier('unset.hookedProperty')
 					->build();
-			} elseif ($this->phpVersion->supportsPropertyHooks()) {
+			} elseif ($this->phpVersion->supportsPropertyHooks() && !$inArrayDimFetch) {
 				if (
 					!$propertyReflection->isPrivate()
 					&& !$propertyReflection->isFinal()->yes()

tests/PHPStan/Rules/Variables/UnsetRuleTest.php

@@ -61,18 +61,7 @@ public function testBug2752(): void
 
 	public function testBug4289(): void
 	{
-		$errors = [];
-
-		if (PHP_VERSION_ID >= 80400) {
-			$errors = [
-				[
-					'Cannot unset property Bug4289\BaseClass::$fields because it might have hooks in a subclass.',
-					25,
-				],
-			];
-		}
-
-		$this->analyse([__DIR__ . '/data/bug-4289.php'], $errors);
+		$this->analyse([__DIR__ . '/data/bug-4289.php'], []);
 	}
 
 	public function testBug5223(): void

tests/PHPStan/Rules/Variables/data/unset-hooked-property.php

@@ -64,3 +64,41 @@ function doFoo() {
 		unset($this->privateProperty);
 	}
 }
+
+class Bug12695
+{
+	/** @var int[] */
+	public array $values = [1];
+	public function test(): void
+	{
+		unset($this->values[0]);
+	}
+}
+
+abstract class Bug12695_AbstractJsonView
+{
+	protected array $variables = [];
+
+	public function render(): array
+	{
+		return $this->variables;
+	}
+}
+
+class Bug12695_GetSeminarDateJsonView extends Bug12695_AbstractJsonView
+{
+	public function render(): array
+	{
+		unset($this->variables['settings']);
+		return parent::render();
+	}
+}
+
+class Bug12695_AddBookingsJsonView extends Bug12695_GetSeminarDateJsonView
+{
+	public function render(): array
+	{
+		unset($this->variables['seminarDate']);
+		return parent::render();
+	}
+}