Add non regression tests

Author: VincentLanglet

tests/PHPStan/Rules/Comparison/StrictComparisonOfDifferentTypesRuleTest.php

@@ -986,6 +986,11 @@ public function testBug12748(): void
 		$this->analyse([__DIR__ . '/data/bug-12748.php'], []);
 	}
 
+	public function testBug3803(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-3803.php'], []);
+	}
+
 	public function testBug11019(): void
 	{
 		$this->analyse([__DIR__ . '/data/bug-11019.php'], []);

tests/PHPStan/Rules/Comparison/data/bug-3803.php

@@ -0,0 +1,16 @@
+<?php declare(strict_types = 1);
+
+namespace Bug3803;
+
+/** @param array<string> $chars */
+function fun(array $chars) : void{
+	$string = "";
+	foreach($chars as $k => $v){
+		$string[$k] = $v;
+	}
+	if($string === "wheee"){
+		var_dump("yes");
+	}
+}
+
+fun(["w", "h", "e", "e", "e"]);

tests/PHPStan/Rules/Variables/UnsetRuleTest.php

@@ -65,6 +65,11 @@ public function testBug4289(): void
 		$this->analyse([__DIR__ . '/data/bug-4289.php'], []);
 	}
 
+	public function testBug4204(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-4204.php'], []);
+	}
+
 	public function testBug5223(): void
 	{
 		$this->analyse([__DIR__ . '/../../Analyser/nsrt/bug-5223.php'], [

tests/PHPStan/Rules/Variables/data/bug-4204.php

@@ -0,0 +1,27 @@
+<?php declare(strict_types = 1);
+
+namespace Bug4204;
+
+interface Block
+{
+	public function getSettings(): mixed;
+}
+
+class HelloWorld
+{
+	/**
+	 * @param array<int, object> $blocks
+	 */
+	public function sayHello(array $blocks): void
+	{
+		foreach ($blocks as $block) {
+			$settings = $block->getSettings();
+
+			if (isset($settings['name'])) {
+				// switch name with code key
+				$settings['code'] = $settings['name'];
+				unset($settings['name']);
+			}
+		}
+	}
+}