fix build

Author: staabm

src/Reflection/BetterReflection/SourceLocator/FileReadTrapStreamWrapper.php

@@ -212,6 +212,9 @@ public function stream_eof(): bool
 		return $this->readFromFile;
 	}
 
+	/**
+	 * @return true
+	 */
 	public function stream_flush(): bool
 	{
 		return true;
@@ -254,6 +257,8 @@ public function stream_seek($offset, $whence): bool
 	 * @param int  $option
 	 * @param int  $arg1
 	 * @param int  $arg2
+	 *
+	 * @return false
 	 */
 	public function stream_set_option($option, $arg1, $arg2): bool
 	{

tests/PHPStan/Analyser/AnalyserIntegrationTest.php

@@ -1098,15 +1098,23 @@ public function testBug8376(): void
 	public function testAssertDocblock(): void
 	{
 		$errors = $this->runAnalyse(__DIR__ . '/nsrt/assert-docblock.php');
-		$this->assertCount(4, $errors);
-		$this->assertSame('Call to method AssertDocblock\A::testInt() with string will always evaluate to false.', $errors[0]->getMessage());
-		$this->assertSame(218, $errors[0]->getLine());
-		$this->assertSame('Call to method AssertDocblock\A::testNotInt() with string will always evaluate to true.', $errors[1]->getMessage());
-		$this->assertSame(224, $errors[1]->getLine());
-		$this->assertSame('Call to method AssertDocblock\A::testInt() with int will always evaluate to true.', $errors[2]->getMessage());
-		$this->assertSame(232, $errors[2]->getLine());
-		$this->assertSame('Call to method AssertDocblock\A::testNotInt() with int will always evaluate to false.', $errors[3]->getMessage());
-		$this->assertSame(238, $errors[3]->getLine());
+		$this->assertCount(8, $errors);
+		$this->assertSame('Function AssertDocblock\validateStringArrayIfTrue() never returns false so it can be removed from the return type.', $errors[0]->getMessage());
+		$this->assertSame(17, $errors[0]->getLine());
+		$this->assertSame('Function AssertDocblock\validateStringArrayIfFalse() never returns true so it can be removed from the return type.', $errors[1]->getMessage());
+		$this->assertSame(25, $errors[1]->getLine());
+		$this->assertSame('Function AssertDocblock\validateStringOrIntArray() never returns true so it can be removed from the return type.', $errors[2]->getMessage());
+		$this->assertSame(34, $errors[2]->getLine());
+		$this->assertSame('Function AssertDocblock\validateStringOrNonEmptyIntArray() never returns true so it can be removed from the return type.', $errors[3]->getMessage());
+		$this->assertSame(44, $errors[3]->getLine());
+		$this->assertSame('Call to method AssertDocblock\A::testInt() with string will always evaluate to false.', $errors[4]->getMessage());
+		$this->assertSame(218, $errors[4]->getLine());
+		$this->assertSame('Call to method AssertDocblock\A::testNotInt() with string will always evaluate to true.', $errors[5]->getMessage());
+		$this->assertSame(224, $errors[5]->getLine());
+		$this->assertSame('Call to method AssertDocblock\A::testInt() with int will always evaluate to true.', $errors[6]->getMessage());
+		$this->assertSame(232, $errors[6]->getLine());
+		$this->assertSame('Call to method AssertDocblock\A::testNotInt() with int will always evaluate to false.', $errors[7]->getMessage());
+		$this->assertSame(238, $errors[7]->getLine());
 	}
 
 	#[RequiresPhp('>= 8.0')]

tests/PHPStan/Analyser/nsrt/assert-docblock.php

@@ -13,7 +13,6 @@ function validateStringArray(array $arr) : void {}
 /**
  * @param mixed[] $arr
  * @phpstan-assert-if-true string[] $arr
- * @return true
  */
 function validateStringArrayIfTrue(array $arr) : bool {
 	return true;

tests/PHPStan/Rules/Comparison/DoWhileLoopConstantConditionRuleTest.php

@@ -11,6 +11,7 @@
 class DoWhileLoopConstantConditionRuleTest extends RuleTestCase
 {
 
+	/** @var true */
 	private bool $treatPhpDocTypesAsCertain = true;
 
 	protected function getRule(): Rule

tests/PHPStan/Rules/Comparison/LogicalXorConstantConditionRuleTest.php

@@ -11,8 +11,10 @@
 class LogicalXorConstantConditionRuleTest extends RuleTestCase
 {
 
+	/** @var true */
 	private bool $treatPhpDocTypesAsCertain;
 
+	/** @var false */
 	private bool $reportAlwaysTrueInLastCondition = false;
 
 	protected function getRule(): TRule

tests/PHPStan/Rules/Comparison/WhileLoopAlwaysFalseConditionRuleTest.php

@@ -11,6 +11,7 @@
 class WhileLoopAlwaysFalseConditionRuleTest extends RuleTestCase
 {
 
+	/** @var true */
 	private bool $treatPhpDocTypesAsCertain = true;
 
 	protected function getRule(): Rule

tests/PHPStan/Rules/Comparison/WhileLoopAlwaysTrueConditionRuleTest.php

@@ -11,6 +11,7 @@
 class WhileLoopAlwaysTrueConditionRuleTest extends RuleTestCase
 {
 
+	/** @var true */
 	private bool $treatPhpDocTypesAsCertain = true;
 
 	protected function getRule(): Rule

tests/PHPStan/Rules/Exceptions/TooWideFunctionThrowTypeRuleTest.php

@@ -11,6 +11,7 @@
 class TooWideFunctionThrowTypeRuleTest extends RuleTestCase
 {
 
+	/** @var true */
 	private bool $implicitThrows = true;
 
 	protected function getRule(): Rule

tests/PHPStan/Rules/Exceptions/TooWidePropertyHookThrowTypeRuleTest.php

@@ -13,6 +13,7 @@
 class TooWidePropertyHookThrowTypeRuleTest extends RuleTestCase
 {
 
+	/** @var true */
 	private bool $implicitThrows = true;
 
 	protected function getRule(): Rule

tests/PHPStan/Rules/Functions/ArrayValuesRuleTest.php

@@ -12,6 +12,7 @@
 class ArrayValuesRuleTest extends RuleTestCase
 {
 
+	/** @var true */
 	private bool $treatPhpDocTypesAsCertain = true;
 
 	protected function getRule(): Rule