Property tag @property-read with private property keeps the property non-writable

Author: ondrejmirtes

src/Reflection/Annotations/AnnotationsPropertiesClassReflectionExtension.php

@@ -47,8 +47,10 @@ private function findClassReflectionWithProperty(
 			$isWritable = $propertyTags[$propertyName]->isWritable();
 			if ($classReflection->hasNativeProperty($propertyName)) {
 				$nativeProperty = $classReflection->getNativeProperty($propertyName);
-				$isReadable = $isReadable || $nativeProperty->isReadable();
-				$isWritable = $isWritable || $nativeProperty->isWritable();
+				if (!$nativeProperty->isPrivate() && !$nativeProperty->isStatic()) {
+					$isReadable = $isReadable || $nativeProperty->isReadable();
+					$isWritable = $isWritable || $nativeProperty->isWritable();
+				}
 			}
 
 			return new AnnotationPropertyReflection(

src/Reflection/Php/PhpClassReflectionExtension.php

@@ -216,7 +216,7 @@ private function createProperty(
 					$types[] = $value;
 				}
 
-				return new PhpPropertyReflection($declaringClassReflection, null, null, TypeCombinator::union(...$types), $classReflection->getNativeReflection()->getProperty($propertyName), null, null, null, false, false, false, false, [], false);
+				return new PhpPropertyReflection($declaringClassReflection, null, null, TypeCombinator::union(...$types), $classReflection->getNativeReflection()->getProperty($propertyName), null, null, null, false, false, false, false, [], false, true, false);
 			}
 		}
 
@@ -433,6 +433,8 @@ private function createProperty(
 					$isAllowedPrivateMutation,
 					$this->attributeReflectionFactory->fromNativeReflection($propertyReflection->getAttributes(), InitializerExprContext::fromClass($declaringClassReflection->getName(), $declaringClassReflection->getFileName())),
 					$isFinal,
+					$annotationProperty->isReadable(),
+					$annotationProperty->isWritable(),
 				);
 			}
 		}
@@ -452,6 +454,8 @@ private function createProperty(
 			$isAllowedPrivateMutation,
 			$this->attributeReflectionFactory->fromNativeReflection($propertyReflection->getAttributes(), InitializerExprContext::fromClass($declaringClassReflection->getName(), $declaringClassReflection->getFileName())),
 			$isFinal,
+			true,
+			true,
 		);
 	}
 

src/Reflection/Php/PhpPropertyReflection.php

@@ -45,6 +45,8 @@ public function __construct(
 		private bool $isAllowedPrivateMutation,
 		private array $attributes,
 		private bool $isFinal,
+		private bool $readable,
+		private bool $writable,
 	)
 	{
 	}
@@ -176,6 +178,10 @@ public function getNativeType(): Type
 
 	public function isReadable(): bool
 	{
+		if (!$this->readable) {
+			return false;
+		}
+
 		if ($this->isStatic()) {
 			return true;
 		}
@@ -189,6 +195,10 @@ public function isReadable(): bool
 
 	public function isWritable(): bool
 	{
+		if (!$this->writable) {
+			return false;
+		}
+
 		if ($this->isStatic()) {
 			return true;
 		}

tests/PHPStan/Rules/Properties/WritingToReadOnlyPropertiesRuleTest.php

@@ -111,4 +111,15 @@ public function testBug12553(): void
 		$this->analyse([__DIR__ . '/../Variables/data/bug-12553.php'], []);
 	}
 
+	public function testPrivatePropertyTagRead(): void
+	{
+		$this->checkThisOnly = false;
+		$this->analyse([__DIR__ . '/data/private-property-tag-read.php'], [
+			[
+				'Property PrivatePropertyTagRead\Foo::$foo is not writable.',
+				22,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Properties/data/private-property-tag-read.php

@@ -0,0 +1,24 @@
+<?php
+
+namespace PrivatePropertyTagRead;
+
+use AllowDynamicProperties;
+
+/**
+ * @property-read int $foo
+ * @property-read int $bar
+ */
+#[AllowDynamicProperties]
+class Foo
+{
+
+	private int $foo;
+
+	public int $bar;
+
+}
+
+function (Foo $foo): void {
+	$foo->foo = 1;
+	$foo->bar = 2;
+};