resolve feedback

Addresses #3613 (comment)

Instead of a 4-part if/elseif/else, this builds both lowercase and/or uppercase; then if neither was true, builds what would have been the final else case.

Author: pmjones

src/Type/Php/ParseUrlFunctionDynamicReturnTypeExtension.php

@@ -211,15 +211,19 @@ private function createComponentsArray(bool $urlIsLowercase, bool $urlIsUppercas
 			foreach ($this->componentTypesPairedStringsForLowercaseString as $componentName => $componentValueType) {
 				$builder->setOffsetValueType(new ConstantStringType($componentName), $componentValueType, true);
 			}
-		} elseif ($urlIsUppercase) {
+		}
+
+		if ($urlIsUppercase) {
 			if ($this->componentTypesPairedStringsForUppercaseString === null) {
 				throw new ShouldNotHappenException();
 			}
 
 			foreach ($this->componentTypesPairedStringsForUppercaseString as $componentName => $componentValueType) {
 				$builder->setOffsetValueType(new ConstantStringType($componentName), $componentValueType, true);
 			}
-		} else {
+		}
+
+		if (! $urlIsLowercase && ! $urlIsUppercase) {
 			if ($this->componentTypesPairedStrings === null) {
 				throw new ShouldNotHappenException();
 			}